Skip to content

no warn if pathMatch is empty (fix #3072)#3081

Merged
posva merged 1 commit intovuejs:devfrom
yinm:fix-pathMatch-warn
Dec 30, 2019
Merged

no warn if pathMatch is empty (fix #3072)#3081
posva merged 1 commit intovuejs:devfrom
yinm:fix-pathMatch-warn

Conversation

@yinm
Copy link
Copy Markdown
Contributor

@yinm yinm commented Dec 26, 2019

Try to fix #3072
if pathMatch is empty, skip warning.

@yinm yinm marked this pull request as ready for review December 26, 2019 12:50
Comment thread src/util/params.js Outdated
@yinm yinm force-pushed the fix-pathMatch-warn branch from aac5049 to 590adbb Compare December 27, 2019 11:58
Comment thread src/util/params.js

return filler(params, { pretty: true })
} catch (e) {
if (process.env.NODE_ENV !== 'production') {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the if was necessary though

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, I revert it

@yinm yinm force-pushed the fix-pathMatch-warn branch from 8a213d9 to 590adbb Compare December 27, 2019 23:04
Copy link
Copy Markdown
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Named catch-all route warns if pathMatch is empty

2 participants