Skip to content

pre-announcement of changes to LESS syntax #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
braver opened this issue Nov 15, 2018 · 8 comments
Closed

pre-announcement of changes to LESS syntax #169

braver opened this issue Nov 15, 2018 · 8 comments

Comments

@braver
Copy link
Contributor

braver commented Nov 15, 2018

A few months ago a new version of LESS was released that changed the root selector to source.css.less. The intention at the time was to bring the syntax in line with CSS, and thereby make more extensions like autocompletion and key bindings work for both out of the box. It got us 95% of the way there, but the recursion in LESS (and SCSS for that matter) makes it impossible to get there completely. In essence, the CSS syntax, and therefore its autocomplete features, leans heavily on the fact that properties and selectors are each in their own neatly delineated spaces. This doesn't always work for LESS, and the way extensions are inherited doesn't leave us another option than making a clean break.

So, I intend to release LESS 2.5 soon. It has important improvements that are only possible by moving a few steps away from the way the CSS package does things. It will also revert the root scope back to source.less. I would like to coordinate this release so that Vue users don't experience breakage again (sorry about last time!). If all goes well no-one has to notice anything. Perhaps we can pick a time and date to make the change?

@LinusBorg
Copy link
Member

LinusBorg commented Nov 15, 2018

Hey @braver,

thank you very much for reaching out proactively, highly appreachiated.

I'm currently trying to find the best team member(s) to discuss this with you (I'm not one of those., for sure) - can you give me a bit more info, since I don't clearly understand the scope of the change you are talking about:

  • is this about Less syntax getting a breaking change for people writing LESS?
  • Or is it about changes specifically related to syntax highlighting of LESS code, but authors writing LESS markup won't be affected?
  • Since this repo is about the sublim syntax highlighting specifically: is ithis only about sublime, or something more general?

Apologies for asking potentially stupid questions, just wanna wrap my head around the scope of this challenge so I know who to involve.

@braver
Copy link
Contributor Author

braver commented Nov 15, 2018

@LinusBorg Hi, the vue syntax imports the LESS syntax via its scope. Basically what needs to be done is revert this commit: 2e8c5b9

@LinusBorg
Copy link
Member

Thanks, got it.

@skyronic
Copy link
Collaborator

Hi @braver that sounds good. Thank you for letting us know. Can you email me at [email protected] to schedule a time to make the switch?

@braver
Copy link
Contributor Author

braver commented Nov 20, 2018

@skyronic I just tagged LESS 2.5.0 with the proposed changes.

@skyronic
Copy link
Collaborator

@braver thank you! I've tagged v3.3.4 on 074fbc0 as well.

I still don't have LESS 2.5.0 in my package list, I'll be sure to double check and test again before closing this issue.

Thanks again for your help!

@braver
Copy link
Contributor Author

braver commented Nov 20, 2018

I still don't have LESS 2.5.0 in my package list

package control can need over an hour to catch the updates, I'll keep an eye on it.

@skyronic
Copy link
Collaborator

Looks like everything is working well. Please feel free to re-open if any action is required.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants