Skip to content

<a> and <area> are not window named objects #3013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2017
Merged

<a> and <area> are not window named objects #3013

merged 1 commit into from
Sep 6, 2017

Conversation

@annevk
Copy link
Member

@annevk annevk commented Sep 6, 2017

This was missed in #1869.

@annevk annevk mentioned this pull request Sep 6, 2017
Closed
annevk pushed a commit to web-platform-tests/wpt that referenced this pull request Sep 6, 2017
@ayg @annevk
Rewrite document named property tests
9ee63dc 
Incorperates whatwg/html#2930 and whatwg/html#3013.
@annevk annevk mentioned this pull request Sep 6, 2017
Open
@annevk
Copy link
Member Author

annevk commented Sep 6, 2017

Tests: web-platform-tests/wpt#7266.

@domenic
Copy link
Member

domenic commented Sep 6, 2017

Did we figure out why, per #2940 (comment) ,

somehow all browsers do pass the relevant test at http://w3c-test.org/html/browsers/the-window-object/named-access-on-the-window-object/named-objects.html

?

Without knowing that it's hard to say whether we're finally fixing this or if there's more confusion lurking.

@annevk
Copy link
Member Author

annevk commented Sep 6, 2017

Isn't that because of web-platform-tests/wpt@1341204?

@domenic
Copy link
Member

domenic commented Sep 6, 2017

Hmm, in that case I am confused by web-platform-tests/wpt#7266 . Is the only new thing it's testing #2930 ? But we haven't even gotten agreement on that behavior, so why are we rewriting the tests to test it?

@annevk
Copy link
Member Author

annevk commented Sep 6, 2017

Good question, not sure, and I don't expect we'll hear from @ayg anytime soon. We should fix this though and the test (subtest two in particular) you pointed to above should also be fixed.

annevk added a commit to web-platform-tests/wpt that referenced this pull request Sep 6, 2017
@annevk
Regression fix: remove redundant and incorrect array length assert
f24c9aa 
Came up in whatwg/html#3013. Regressed in 208fa49.
@annevk annevk mentioned this pull request Sep 6, 2017
Merged
domenic
domenic approved these changes Sep 6, 2017
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's not mention that test PR in the commit message since it's actually testing something very different.

@annevk annevk merged commit 9c20952 into master Sep 6, 2017
@annevk annevk deleted the ayg/window-named-items branch September 6, 2017 14:29
annevk added a commit to web-platform-tests/wpt that referenced this pull request Sep 7, 2017
@annevk
Regression fix: remove redundant and incorrect array length assert
c3bc351 
Came up in whatwg/html#3013. Regressed in 208fa49.
rachelandrew pushed a commit to rachelandrew/web-platform-tests that referenced this pull request Nov 8, 2017
@annevk @rachelandrew
Regression fix: remove redundant and incorrect array length assert
2a4af41 
Came up in whatwg/html#3013. Regressed in 208fa49.
jakearchibald pushed a commit to jakearchibald/web-platform-tests that referenced this pull request Nov 16, 2017
@annevk @jakearchibald
Regression fix: remove redundant and incorrect array length assert
7dfe982 
Came up in whatwg/html#3013. Regressed in 208fa49.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domenic domenic domenic approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@annevk @domenic @ayg