Let the popstate and hashchange events not bubble #3737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Out of Chrome, Edge, Firefox and Safari, only Firefox sets bubbles to true for these events. Since they are dispatched on the window object, that is not particularly meaningful, so match the 3/4 majority. Tests: web-platform-tests/wpt#11355
foolip
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 5, 2018
annevk
reviewed
Jun 5, 2018
source
Outdated
| <var>new URL</var>.</p></li> | ||
| context</span>'s <code>Window</code> object, using <code>HashChangeEvent</code>, with the | ||
| <code data-x="dom-HashChangeEvent-oldURL">oldURL</code> attribute initialized to <var>old | ||
| URL</var>, and the <code data-x="dom-HashChangeEvent-newURL">newURL</code> attribute |
Member
There was a problem hiding this comment.
No need for a comma here before the and since it's only joining two things.
Member
|
@bzbarsky @smaug---- any concerns? |
|
Should be fine. If we have some internal code which depends on this, it is broken anyhow, but I don't expect there to be. |
Contributor
|
Yeah, this seems fine. |
annevk
approved these changes
Jun 7, 2018
Member
|
@foolip can you file the necessary bugs? |
annevk
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 7, 2018
Member
Author
dheiberg
pushed a commit
to dheiberg/wpt
that referenced
this pull request
Jun 7, 2018
Zirro
added a commit
to Zirro/web-platform-tests
that referenced
this pull request
Jun 26, 2018
domenic
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 26, 2018
This brings the `html/browsers/browsing-the-web/scroll-to-fragid/004.html` test up to date with the spec change made here: whatwg/html#3737. Other tests were changed to reflect this in #11355.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 27, 2018
…a=testonly Automatic update from web-platform-testsHTML: update hashchange/popstate event tests For whatwg/html#3737. -- wpt-commits: 81303e16ee14b318d07c9aeb56e16e7499647b7a wpt-pr: 11355
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 28, 2018
…a=testonly Automatic update from web-platform-testsHTML: update hashchange/popstate event tests For whatwg/html#3737. -- wpt-commits: 81303e16ee14b318d07c9aeb56e16e7499647b7a wpt-pr: 11355
lukebjerring
pushed a commit
to lukebjerring/wpt
that referenced
this pull request
Jun 29, 2018
This brings the `html/browsers/browsing-the-web/scroll-to-fragid/004.html` test up to date with the spec change made here: whatwg/html#3737. Other tests were changed to reflect this in web-platform-tests#11355.
kdashg
pushed a commit
to kdashg/gecko-cinn
that referenced
this pull request
Jun 30, 2018
…a=testonly Automatic update from web-platform-testsHTML: update hashchange/popstate event tests For whatwg/html#3737. -- wpt-commits: 81303e16ee14b318d07c9aeb56e16e7499647b7a wpt-pr: 11355
kdashg
pushed a commit
to kdashg/gecko-cinn
that referenced
this pull request
Jun 30, 2018
…a=testonly Automatic update from web-platform-testsHTML: update hashchange/popstate event tests For whatwg/html#3737. -- wpt-commits: 81303e16ee14b318d07c9aeb56e16e7499647b7a wpt-pr: 11355
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 11, 2018
…a=testonly Automatic update from web-platform-testsThe hashchange event should not bubble This brings the `html/browsers/browsing-the-web/scroll-to-fragid/004.html` test up to date with the spec change made here: whatwg/html#3737. Other tests were changed to reflect this in web-platform-tests/wpt#11355. -- wpt-commits: 3aaef8d2cac4ab2044a1ba01895f2e028b91d996 wpt-pr: 11672
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…a=testonly Automatic update from web-platform-testsHTML: update hashchange/popstate event tests For whatwg/html#3737. -- wpt-commits: 81303e16ee14b318d07c9aeb56e16e7499647b7a wpt-pr: 11355 UltraBlame original commit: 3f8d8f2c37e160fc95ce891620a10f6b832b8da6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…a=testonly Automatic update from web-platform-testsHTML: update hashchange/popstate event tests For whatwg/html#3737. -- wpt-commits: 81303e16ee14b318d07c9aeb56e16e7499647b7a wpt-pr: 11355 UltraBlame original commit: d97405360c9af7a51a24881e2664424f6b36b003
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…a=testonly Automatic update from web-platform-testsThe hashchange event should not bubble This brings the `html/browsers/browsing-the-web/scroll-to-fragid/004.html` test up to date with the spec change made here: whatwg/html#3737. Other tests were changed to reflect this in web-platform-tests/wpt#11355. -- wpt-commits: 3aaef8d2cac4ab2044a1ba01895f2e028b91d996 wpt-pr: 11672 UltraBlame original commit: ae0bb1f940e178bc39c17224d1fa264af2deacb4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…a=testonly Automatic update from web-platform-testsHTML: update hashchange/popstate event tests For whatwg/html#3737. -- wpt-commits: 81303e16ee14b318d07c9aeb56e16e7499647b7a wpt-pr: 11355 UltraBlame original commit: 3f8d8f2c37e160fc95ce891620a10f6b832b8da6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…a=testonly Automatic update from web-platform-testsHTML: update hashchange/popstate event tests For whatwg/html#3737. -- wpt-commits: 81303e16ee14b318d07c9aeb56e16e7499647b7a wpt-pr: 11355 UltraBlame original commit: d97405360c9af7a51a24881e2664424f6b36b003
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…a=testonly Automatic update from web-platform-testsThe hashchange event should not bubble This brings the `html/browsers/browsing-the-web/scroll-to-fragid/004.html` test up to date with the spec change made here: whatwg/html#3737. Other tests were changed to reflect this in web-platform-tests/wpt#11355. -- wpt-commits: 3aaef8d2cac4ab2044a1ba01895f2e028b91d996 wpt-pr: 11672 UltraBlame original commit: ae0bb1f940e178bc39c17224d1fa264af2deacb4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…a=testonly Automatic update from web-platform-testsHTML: update hashchange/popstate event tests For whatwg/html#3737. -- wpt-commits: 81303e16ee14b318d07c9aeb56e16e7499647b7a wpt-pr: 11355 UltraBlame original commit: 3f8d8f2c37e160fc95ce891620a10f6b832b8da6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…a=testonly Automatic update from web-platform-testsHTML: update hashchange/popstate event tests For whatwg/html#3737. -- wpt-commits: 81303e16ee14b318d07c9aeb56e16e7499647b7a wpt-pr: 11355 UltraBlame original commit: d97405360c9af7a51a24881e2664424f6b36b003
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…a=testonly Automatic update from web-platform-testsThe hashchange event should not bubble This brings the `html/browsers/browsing-the-web/scroll-to-fragid/004.html` test up to date with the spec change made here: whatwg/html#3737. Other tests were changed to reflect this in web-platform-tests/wpt#11355. -- wpt-commits: 3aaef8d2cac4ab2044a1ba01895f2e028b91d996 wpt-pr: 11672 UltraBlame original commit: ae0bb1f940e178bc39c17224d1fa264af2deacb4
jwidar
pushed a commit
to jwidar/LatencyZeroGithub
that referenced
this pull request
Sep 16, 2025
…a=testonly Automatic update from web-platform-testsHTML: update hashchange/popstate event tests For whatwg/html#3737. -- wpt-commits: 81303e16ee14b318d07c9aeb56e16e7499647b7a wpt-pr: 11355
jwidar
pushed a commit
to jwidar/LatencyZeroGithub
that referenced
this pull request
Sep 16, 2025
…a=testonly Automatic update from web-platform-testsHTML: update hashchange/popstate event tests For whatwg/html#3737. -- wpt-commits: 81303e16ee14b318d07c9aeb56e16e7499647b7a wpt-pr: 11355
jwidar
pushed a commit
to jwidar/LatencyZeroGithub
that referenced
this pull request
Sep 16, 2025
…a=testonly Automatic update from web-platform-testsThe hashchange event should not bubble This brings the `html/browsers/browsing-the-web/scroll-to-fragid/004.html` test up to date with the spec change made here: whatwg/html#3737. Other tests were changed to reflect this in web-platform-tests/wpt#11355. -- wpt-commits: 3aaef8d2cac4ab2044a1ba01895f2e028b91d996 wpt-pr: 11672
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Out of Chrome, Edge, Firefox and Safari, only Firefox sets bubbles to
true for these events. Since they are dispatched on the window object,
that is not particularly meaningful, so match the 3/4 majority.
Tests: web-platform-tests/wpt#11355
/browsing-the-web.html ( diff )