`yarn upgrade` does not update package.json

[milesj]

Do you want to request a feature or report a bug?

Bug (or maybe request)?

What is the current behavior?

Running yarn upgrade will update dependencies, but not update the versions in package.json.

If the current behavior is a bug, please provide the steps to reproduce.

Here's an output of my console logs.

[16:05:27] Miles:aesthetic > yarn outdated
yarn outdated v0.17.8
Package                 Current Wanted Latest Package Type   
eslint                  3.10.2  3.11.0 3.11.0 devDependencies
mocha                   3.1.2   3.2.0  3.2.0  devDependencies
react                   15.4.0  15.4.1 15.4.1 devDependencies
react-addons-test-utils 15.4.0  15.4.1 15.4.1 devDependencies
react-dom               15.4.0  15.4.1 15.4.1 devDependencies
eslint-plugin-jsx-a11y  2.2.3   2.2.3  3.0.1  devDependencies
flow-bin                0.35.0  0.35.0 0.36.0 devDependencies
✨  Done in 0.49s.
[16:05:30] Miles:aesthetic > gs
# On branch: master  |  No changes (working directory clean)
[16:05:31] Miles:aesthetic > yarn upgrade --ignore-engines
yarn upgrade v0.17.8
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
success Saved lockfile.
success Saved 448 new dependencies.
├─ abbrev@1.0.9
├─ acorn-jsx@3.0.1
├─ acorn@4.0.3
├─ ajv-keywords@1.1.1
├─ ajv@4.9.0
├─ ansi-escapes@1.4.0
├─ ansi-regex@2.0.0
├─ ansi-styles@2.2.1
├─ anymatch@1.3.0
├─ aphrodite@1.1.0
├─ aproba@1.0.4
├─ are-we-there-yet@1.1.2
├─ argparse@1.0.9
├─ arr-diff@2.0.0
├─ arr-flatten@1.0.1
├─ array-union@1.0.2
├─ array-uniq@1.0.3
├─ array-unique@0.2.1
├─ arrify@1.0.1
├─ asap@2.0.5
├─ asn1@0.2.3
├─ assert-plus@0.2.0
├─ assertion-error@1.0.2
├─ async-each@1.0.1
├─ asynckit@0.4.0
├─ aws-sign2@0.6.0
├─ aws4@1.5.0
├─ babel-cli@6.18.0
├─ babel-code-frame@6.16.0
├─ babel-core@6.18.2
├─ babel-eslint@7.1.1
├─ babel-generator@6.19.0
├─ babel-helper-bindify-decorators@6.18.0
├─ babel-helper-builder-binary-assignment-operator-visitor@6.18.0
├─ babel-helper-builder-react-jsx@6.18.0
├─ babel-helper-call-delegate@6.18.0
├─ babel-helper-define-map@6.18.0
├─ babel-helper-explode-assignable-expression@6.18.0
├─ babel-helper-explode-class@6.18.0
├─ babel-helper-function-name@6.18.0
├─ babel-helper-get-function-arity@6.18.0
├─ babel-helper-hoist-variables@6.18.0
├─ babel-helper-optimise-call-expression@6.18.0
├─ babel-helper-regex@6.18.0
├─ babel-helper-remap-async-to-generator@6.18.0
├─ babel-helper-replace-supers@6.18.0
├─ babel-helpers@6.16.0
├─ babel-messages@6.8.0
├─ babel-plugin-check-es2015-constants@6.8.0
├─ babel-plugin-syntax-async-functions@6.13.0
├─ babel-plugin-syntax-async-generators@6.13.0
├─ babel-plugin-syntax-class-properties@6.13.0
├─ babel-plugin-syntax-decorators@6.13.0
├─ babel-plugin-syntax-dynamic-import@6.18.0
├─ babel-plugin-syntax-exponentiation-operator@6.13.0
├─ babel-plugin-syntax-flow@6.18.0
├─ babel-plugin-syntax-jsx@6.18.0
├─ babel-plugin-syntax-object-rest-spread@6.13.0
├─ babel-plugin-syntax-trailing-function-commas@6.13.0
├─ babel-plugin-transform-async-generator-functions@6.17.0
├─ babel-plugin-transform-async-to-generator@6.16.0
├─ babel-plugin-transform-class-properties@6.19.0
├─ babel-plugin-transform-decorators@6.13.0
├─ babel-plugin-transform-es2015-arrow-functions@6.8.0
├─ babel-plugin-transform-es2015-block-scoped-functions@6.8.0
├─ babel-plugin-transform-es2015-block-scoping@6.18.0
├─ babel-plugin-transform-es2015-classes@6.18.0
├─ babel-plugin-transform-es2015-computed-properties@6.8.0
├─ babel-plugin-transform-es2015-destructuring@6.19.0
├─ babel-plugin-transform-es2015-duplicate-keys@6.8.0
├─ babel-plugin-transform-es2015-for-of@6.18.0
├─ babel-plugin-transform-es2015-function-name@6.9.0
├─ babel-plugin-transform-es2015-literals@6.8.0
├─ babel-plugin-transform-es2015-modules-amd@6.18.0
├─ babel-plugin-transform-es2015-modules-commonjs@6.18.0
├─ babel-plugin-transform-es2015-modules-systemjs@6.19.0
├─ babel-plugin-transform-es2015-modules-umd@6.18.0
├─ babel-plugin-transform-es2015-object-super@6.8.0
├─ babel-plugin-transform-es2015-parameters@6.18.0
├─ babel-plugin-transform-es2015-shorthand-properties@6.18.0
├─ babel-plugin-transform-es2015-spread@6.8.0
├─ babel-plugin-transform-es2015-sticky-regex@6.8.0
├─ babel-plugin-transform-es2015-template-literals@6.8.0
├─ babel-plugin-transform-es2015-typeof-symbol@6.18.0
├─ babel-plugin-transform-es2015-unicode-regex@6.11.0
├─ babel-plugin-transform-exponentiation-operator@6.8.0
├─ babel-plugin-transform-flow-comments@6.17.0
├─ babel-plugin-transform-flow-strip-types@6.18.0
├─ babel-plugin-transform-object-rest-spread@6.19.0
├─ babel-plugin-transform-react-display-name@6.8.0
├─ babel-plugin-transform-react-jsx-self@6.11.0
├─ babel-plugin-transform-react-jsx-source@6.9.0
├─ babel-plugin-transform-react-jsx@6.8.0
├─ babel-plugin-transform-regenerator@6.16.1
├─ babel-plugin-transform-runtime@6.15.0
├─ babel-plugin-transform-strict-mode@6.18.0
├─ babel-polyfill@6.16.0
├─ babel-preset-es2015@6.18.0
├─ babel-preset-react@6.16.0
├─ babel-preset-stage-2@6.18.0
├─ babel-preset-stage-3@6.17.0
├─ babel-register@6.18.0
├─ babel-runtime@6.18.0
├─ babel-template@6.16.0
├─ babel-traverse@6.19.0
├─ babel-types@6.19.0
├─ babylon@6.14.1
├─ balanced-match@0.4.2
├─ bcrypt-pbkdf@1.0.0
├─ binary-extensions@1.7.0
├─ block-stream@0.0.9
├─ boolbase@1.0.0
├─ boom@2.10.1
├─ bowser@1.5.0
├─ brace-expansion@1.1.6
├─ braces@1.8.5
├─ browser-stdout@1.3.0
├─ buffer-shims@1.0.0
├─ builtin-modules@1.1.1
├─ caller-path@0.1.0
├─ callsites@0.2.0
├─ caseless@0.11.0
├─ chai@3.5.0
├─ chalk@1.1.3
├─ cheerio@0.22.0
├─ chokidar@1.6.1
├─ circular-json@0.3.1
├─ cli-cursor@1.0.2
├─ cli-width@2.1.0
├─ co@4.6.0
├─ code-point-at@1.1.0
├─ combined-stream@1.0.5
├─ commander@2.9.0
├─ concat-map@0.0.1
├─ concat-stream@1.5.2
├─ console-control-strings@1.1.0
├─ contains-path@0.1.0
├─ convert-source-map@1.3.0
├─ core-js@2.4.1
├─ core-util-is@1.0.2
├─ cryptiles@2.0.5
├─ css-select@1.2.0
├─ css-what@2.1.0
├─ d@0.1.1
├─ damerau-levenshtein@1.0.3
├─ dashdash@1.14.1
├─ debug@2.2.0
├─ deep-eql@0.1.3
├─ deep-extend@0.4.1
├─ deep-is@0.1.3
├─ define-properties@1.1.2
├─ del@2.2.2
├─ delayed-stream@1.0.0
├─ delegates@1.0.0
├─ detect-indent@4.0.0
├─ diff@1.4.0
├─ doctrine@1.5.0
├─ dom-serializer@0.1.0
├─ domelementtype@1.3.0
├─ domhandler@2.3.0
├─ domutils@1.5.1
├─ ecc-jsbn@0.1.1
├─ encoding@0.1.12
├─ entities@1.1.1
├─ enzyme@2.6.0
├─ es-abstract@1.6.1
├─ es-to-primitive@1.1.1
├─ es5-ext@0.10.12
├─ es6-iterator@2.0.0
├─ es6-map@0.1.4
├─ es6-set@0.1.4
├─ es6-symbol@3.1.0
├─ es6-weak-map@2.0.1
├─ escape-string-regexp@1.0.5
├─ escope@3.6.0
├─ eslint-config-airbnb-base@10.0.1
├─ eslint-config-airbnb@13.0.0
├─ eslint-import-resolver-node@0.2.3
├─ eslint-module-utils@2.0.0
├─ eslint-plugin-flowtype@2.25.0
├─ eslint-plugin-import@2.2.0
├─ eslint-plugin-jsx-a11y@2.2.3
├─ eslint-plugin-react@6.7.1
├─ eslint@3.11.0
├─ espree@3.3.2
├─ esprima@2.7.3
├─ esrecurse@4.1.0
├─ estraverse@4.2.0
├─ esutils@2.0.2
├─ event-emitter@0.3.4
├─ exit-hook@1.1.1
├─ expand-brackets@0.1.5
├─ expand-range@1.8.2
├─ extend@3.0.0
├─ extglob@0.3.2
├─ extsprintf@1.0.2
├─ fast-levenshtein@2.0.5
├─ fbjs@0.8.6
├─ figures@1.7.0
├─ file-entry-cache@2.0.0
├─ filename-regex@2.0.0
├─ fill-range@2.2.3
├─ find-up@1.1.2
├─ flat-cache@1.2.1
├─ flow-bin@0.35.0
├─ for-in@0.1.6
├─ for-own@0.1.4
├─ foreach@2.0.5
├─ forever-agent@0.6.1
├─ form-data@2.1.2
├─ fs-readdir-recursive@1.0.0
├─ fs.realpath@1.0.0
├─ fsevents@1.0.15
├─ fstream-ignore@1.0.5
├─ fstream@1.0.10
├─ function-bind@1.1.0
├─ function.prototype.name@1.0.0
├─ gauge@2.7.1
├─ generate-function@2.0.0
├─ generate-object-property@1.2.0
├─ getpass@0.1.6
├─ glob-base@0.3.0
├─ glob-parent@2.0.0
├─ glob@7.0.5
├─ globals@9.14.0
├─ globby@5.0.0
├─ graceful-fs@4.1.11
├─ graceful-readlink@1.0.1
├─ growl@1.9.2
├─ har-validator@2.0.6
├─ has-ansi@2.0.0
├─ has-color@0.1.7
├─ has-flag@1.0.0
├─ has-unicode@2.0.1
├─ has@1.0.1
├─ hawk@3.1.3
├─ hoek@2.16.3
├─ hoist-non-react-statics@1.2.0
├─ home-or-tmp@2.0.0
├─ htmlparser2@3.9.2
├─ http-signature@1.1.1
├─ hyphenate-style-name@1.0.2
├─ iconv-lite@0.4.15
├─ ignore@3.2.0
├─ imurmurhash@0.1.4
├─ in-publish@2.0.0
├─ inflight@1.0.6
├─ inherits@2.0.3
├─ ini@1.3.4
├─ inline-style-prefixer@2.0.4
├─ inquirer@0.12.0
├─ interpret@1.0.1
├─ invariant@2.2.2
├─ is-binary-path@1.0.1
├─ is-buffer@1.1.4
├─ is-callable@1.1.3
├─ is-date-object@1.0.1
├─ is-dotfile@1.0.2
├─ is-equal-shallow@0.1.3
├─ is-extendable@0.1.1
├─ is-extglob@1.0.0
├─ is-finite@1.0.2
├─ is-fullwidth-code-point@1.0.0
├─ is-glob@2.0.1
├─ is-in-browser@1.0.2
├─ is-my-json-valid@2.15.0
├─ is-number@2.1.0
├─ is-path-cwd@1.0.0
├─ is-path-in-cwd@1.0.0
├─ is-path-inside@1.0.0
├─ is-posix-bracket@0.1.1
├─ is-primitive@2.0.0
├─ is-property@1.0.2
├─ is-regex@1.0.3
├─ is-resolvable@1.0.0
├─ is-stream@1.1.0
├─ is-subset@0.1.1
├─ is-symbol@1.0.1
├─ is-typedarray@1.0.0
├─ isarray@1.0.0
├─ isobject@2.1.0
├─ isomorphic-fetch@2.2.1
├─ isstream@0.1.2
├─ jodid25519@1.0.2
├─ js-tokens@2.0.0
├─ js-yaml@3.7.0
├─ jsbn@0.1.0
├─ jsesc@1.3.0
├─ json-schema@0.2.3
├─ json-stable-stringify@1.0.1
├─ json-stringify-safe@5.0.1
├─ json3@3.3.2
├─ json5@0.5.0
├─ jsonify@0.0.0
├─ jsonpointer@4.0.0
├─ jsprim@1.3.1
├─ jss@5.5.6
├─ jsx-ast-utils@1.3.4
├─ kind-of@3.0.4
├─ levn@0.3.0
├─ lodash._baseassign@3.2.0
├─ lodash._basecopy@3.0.1
├─ lodash._basecreate@3.0.3
├─ lodash._getnative@3.9.1
├─ lodash._isiterateecall@3.0.9
├─ lodash.assignin@4.2.0
├─ lodash.bind@4.2.1
├─ lodash.cond@4.5.2
├─ lodash.create@3.1.1
├─ lodash.defaults@4.2.0
├─ lodash.filter@4.6.0
├─ lodash.flatten@4.4.0
├─ lodash.foreach@4.5.0
├─ lodash.isarguments@3.1.0
├─ lodash.isarray@3.0.4
├─ lodash.keys@3.1.2
├─ lodash.map@4.6.0
├─ lodash.merge@4.6.0
├─ lodash.pick@4.4.0
├─ lodash.pickby@4.6.0
├─ lodash.reduce@4.6.0
├─ lodash.reject@4.6.0
├─ lodash.some@4.6.0
├─ lodash@4.17.2
├─ loose-envify@1.3.0
├─ micromatch@2.3.11
├─ mime-db@1.25.0
├─ mime-types@2.1.13
├─ minimatch@3.0.3
├─ minimist@0.0.8
├─ mkdirp@0.5.1
├─ mocha@3.2.0
├─ ms@0.7.1
├─ murmurhash-js@1.0.0
├─ mute-stream@0.0.5
├─ nan@2.4.0
├─ natural-compare@1.4.0
├─ node-fetch@1.6.3
├─ node-pre-gyp@0.6.31
├─ nopt@3.0.6
├─ normalize-path@2.0.1
├─ npmlog@4.0.1
├─ nth-check@1.0.1
├─ number-is-nan@1.0.1
├─ oauth-sign@0.8.2
├─ object-assign@4.1.0
├─ object-is@1.0.1
├─ object-keys@1.0.11
├─ object.assign@4.0.4
├─ object.entries@1.0.3
├─ object.omit@2.0.1
├─ object.values@1.0.3
├─ once@1.4.0
├─ onetime@1.1.0
├─ optionator@0.8.2
├─ os-homedir@1.0.2
├─ os-tmpdir@1.0.2
├─ output-file-sync@1.1.2
├─ parse-glob@3.0.4
├─ path-exists@2.1.0
├─ path-is-absolute@1.0.1
├─ path-is-inside@1.0.2
├─ pify@2.3.0
├─ pinkie-promise@2.0.1
├─ pinkie@2.0.4
├─ pkg-dir@1.0.0
├─ pkg-up@1.0.0
├─ pluralize@1.2.1
├─ prelude-ls@1.1.2
├─ preserve@0.2.0
├─ private@0.1.6
├─ process-nextick-args@1.0.7
├─ progress@1.1.8
├─ promise@7.1.1
├─ punycode@1.4.1
├─ qs@6.3.0
├─ randomatic@1.1.6
├─ rc@1.1.6
├─ react-addons-test-utils@15.4.1
├─ react-dom@15.4.1
├─ react@15.4.1
├─ readable-stream@2.0.6
├─ readdirp@2.1.0
├─ readline2@1.0.1
├─ rechoir@0.6.2
├─ regenerate@1.3.2
├─ regenerator-runtime@0.9.6
├─ regex-cache@0.4.3
├─ regexpu-core@2.0.0
├─ regjsgen@0.2.0
├─ regjsparser@0.1.5
├─ repeat-element@1.1.2
├─ repeat-string@1.6.1
├─ repeating@2.0.1
├─ request@2.79.0
├─ require-uncached@1.0.3
├─ resolve-from@1.0.1
├─ resolve@1.1.7
├─ restore-cursor@1.0.1
├─ rimraf@2.5.4
├─ run-async@0.1.0
├─ rx-lite@3.1.2
├─ semver@5.3.0
├─ set-blocking@2.0.0
├─ set-immediate-shim@1.0.1
├─ shelljs@0.7.5
├─ signal-exit@3.0.1
├─ slash@1.0.0
├─ slice-ansi@0.0.4
├─ sntp@1.0.9
├─ source-map-support@0.4.6
├─ source-map@0.5.6
├─ sprintf-js@1.0.3
├─ sshpk@1.10.1
├─ string_decoder@0.10.31
├─ string-width@1.0.2
├─ stringstream@0.0.5
├─ strip-ansi@3.0.1
├─ strip-bom@3.0.0
├─ strip-json-comments@1.0.4
├─ supports-color@3.1.2
├─ table@3.8.3
├─ tar-pack@3.3.0
├─ tar@2.2.1
├─ text-table@0.2.0
├─ through@2.3.8
├─ to-fast-properties@1.0.2
├─ tough-cookie@2.3.2
├─ tryit@1.0.3
├─ tunnel-agent@0.4.3
├─ tweetnacl@0.14.3
├─ type-check@0.3.2
├─ type-detect@1.0.0
├─ typedarray@0.0.6
├─ ua-parser-js@0.7.12
├─ uid-number@0.0.6
├─ user-home@2.0.0
├─ util-deprecate@1.0.2
├─ uuid@2.0.3
├─ v8flags@2.0.11
├─ verror@1.3.6
├─ warning@3.0.0
├─ whatwg-fetch@2.0.1
├─ wide-align@1.1.0
├─ wordwrap@1.0.0
├─ wrappy@1.0.2
├─ write@0.2.1
└─ xtend@4.0.1
✨  Done in 3.72s.
[16:05:41] Miles:aesthetic > gs
# On branch: master  |  [*] => $e*
#
➤ Changes not staged for commit
#
#       modified:  [1] yarn.lock
#
[16:05:54] Miles:aesthetic > yarn outdated
yarn outdated v0.17.8
Package                Current Wanted Latest Package Type   
eslint-plugin-jsx-a11y 2.2.3   2.2.3  3.0.1  devDependencies
flow-bin               0.35.0  0.35.0 0.36.0 devDependencies
✨  Done in 0.54s.

What is the expected behavior?

The package.json versions are updated (including the ^ caret).

Please mention your node.js, yarn and operating system version.

Yarn v0.17.8
Node.js v7.2.0
macOS v10.12.1

More information.

In my projects, I would constantly use npm update --save-dev to update dev dependencies and the package.json with the latest versions. This allows my dev tooling to always stay constant.

However, I would not do the same for non-dev dependencies, as those should be locked into a specific version as to not restrict consumers. For example, supporting React ^15.0.0 instead of ^15.4.1.

[csvan]

As I understand the docs, the package.json file will only be modified if you run upgrade on a particular package: https://yarnpkg.com/en/docs/cli/upgrade

[milesj]

I could of sworn that yarn upgrade also updated package.json at some point in previous versions. Regardless, I believe this should be a feature, perhaps under a flag like --save-dev.

My other issue with upgrading a package directly, is that it updates the version without the ^ caret.

[torifat]

I could of sworn that yarn upgrade also updated package.json at some point in previous versions.

It could be a bug.

I don't think it's necessary to update package.json in this case. You should track your yarn.lock file with git.

[harlantwood]

I also want a way to update my version numbers in package.json when upgrading all packages, mostly because it provides an easy reference to what the current version is (easier than grepping the lockfile).

As a workaround, I am currently doing:

yarn global add npm-check-updates
ncu --upgrade --upgradeAll && yarn upgrade

The last line I alias to yup, so the workaround is not too painful.

[goemaeret]

Maybe a strange question, but is it actually necessary to update the package.json file? Since the specific package versions are locked away in the yarn.lock file I don't really understand why the package.json file still is being updated when running the yarn upgrade command on a specific package... Any reason/explanation for this behaviour?

Thx in advance

[milesj]

@goemaeret While that is correct, I'm just not a fan of adding a version to package.json once and forgetting it forever. I'd rather the lock file and package.json be incremented together.

Just seems odd that the version in the package.json could theoretically be a year old and like 30 versions behind. Furthermore, it's the more human readable version compared to the lock file.

[goemaeret]

@milesj some very clever arguments you pointed out there. Thx a lot!

[rottmann]

yarn upgrade package change the package.json version, i did not find a reason, why yarn upgrade not update the version in package.json?

[mjbates7]

This would be useful to have the package.json file have the up-to-date version numbers so you can see at a glance the version numbers you have

[edmorley]

Interestingly, upgrade-interactive does update package.json even though upgrade doesn't (though perhaps that's because it does the equivalent of yarn upgrade package for each internally.

[mjbates7]

Where is upgrade-interactive documented?

[edmorley]

Only in yarn --help.

#2891 is meaning features are frequently being added without their equivalent docs changes.

[voxsim]

@bestander we can close this O.o