Skip to content

Move Template Haskell splices to end of the file. #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2020
Merged

Move Template Haskell splices to end of the file. #1034

merged 2 commits into from
Feb 15, 2020

Conversation

merijn
Copy link
Contributor

@merijn merijn commented Feb 11, 2020 •
edited
Loading

Accessing definition across TH splices is an error and 8.10 seems to break on this. See #1033.

Before submitting your PR, check that you've:

  • Bumped the version number

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@merijn
Move Template Haskell splices to end of the file.
3b8cd1d 
Accessing definition across TH splices is an error and 8.10 seems to
break on this.
@merijn
Update changelog and bump version.
2623b5f
@parsonsmatt parsonsmatt merged commit 6d134f7 into yesodweb:master Feb 15, 2020
@parsonsmatt
Copy link
Collaborator

released, thanks!

@merijn merijn deleted the th-fix branch May 12, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merijn @parsonsmatt