Skip to content

ruby: Add ruby-lsp as an experimental language server #11768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2024

Conversation

vitallium
Copy link
Contributor

@vitallium vitallium commented May 13, 2024

Adds ruby-lsp as an alternative LS for Ruby language.
While support for fully functional ruby-lsp is limited due to some limitations (see #8613) I think it's OK to add it but disable by default. Thanks!

Resolves #4834.

Release Notes:

  • N/A

Some screenshots

Completion support
CleanShot 2024-05-13 at 22 58 23@2x

Symbol search
CleanShot 2024-05-13 at 23 03 59@2x

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label May 13, 2024
@vitallium vitallium force-pushed the vs/ruby-lsp-support branch from 9dc4acd to 3d90c62 Compare May 13, 2024 21:03
@vitallium vitallium marked this pull request as ready for review May 13, 2024 21:07
@vitallium vitallium changed the title Add ruby-lsp experimental support for Ruby Add ruby-lsp for Ruby as an experimental language server May 13, 2024
_ => None,
}
}

fn language_server_initialization_options(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was taken from #8613

@maxdeviant maxdeviant changed the title Add ruby-lsp for Ruby as an experimental language server ruby: Add ruby-lsp as an experimental language server May 13, 2024
@maxdeviant maxdeviant self-assigned this May 13, 2024
Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitallium Thanks!

@maxdeviant maxdeviant merged commit 24cc4c6 into zed-industries:main May 13, 2024
8 checks passed
@vitallium
Copy link
Contributor Author

@maxdeviant, that was fast! You're welcome. And thank you for creating a separate PR to bump the version.

@vitallium vitallium deleted the vs/ruby-lsp-support branch May 13, 2024 21:30
maxdeviant added a commit that referenced this pull request May 13, 2024
This PR bumps the Ruby extension to v0.0.2.

Changes:

- #11768

Release Notes:

- N/A
@andyw8
Copy link
Contributor

andyw8 commented May 14, 2024

That's great to hear, I've opened a PR to update the Ruby LSP docs:
Shopify/ruby-lsp#2046

osiewicz pushed a commit to RemcoSmitsDev/zed that referenced this pull request May 18, 2024
…#11768)

Adds [ruby-lsp](https://shopify.github.io/ruby-lsp/) as an alternative
LS for Ruby language.
While support for fully functional `ruby-lsp` is limited due to some
limitations (see zed-industries#8613) I
think it's OK to add it but disable by default. Thanks!

Resolves zed-industries#4834.

Release Notes:

- N/A

### Some screenshots

Completion support
![CleanShot 2024-05-13 at 22 58
23@2x](https://github.com/zed-industries/zed/assets/1894248/d5047baa-c58f-465d-ae31-a7045aa56adf)

Symbol search
![CleanShot 2024-05-13 at 23 03
59@2x](https://github.com/zed-industries/zed/assets/1894248/0cb6320a-b000-4a0c-85eb-f8d1a8f6936e)

---------

Co-authored-by: Marshall Bowers <[email protected]>
osiewicz pushed a commit to RemcoSmitsDev/zed that referenced this pull request May 18, 2024
This PR bumps the Ruby extension to v0.0.2.

Changes:

- zed-industries#11768

Release Notes:

- N/A
notpeter pushed a commit to zed-extensions/ruby that referenced this pull request Oct 11, 2024
…1768)

Adds [ruby-lsp](https://shopify.github.io/ruby-lsp/) as an alternative
LS for Ruby language.
While support for fully functional `ruby-lsp` is limited due to some
limitations (see zed-industries/zed#8613) I
think it's OK to add it but disable by default. Thanks!

Resolves zed-industries/zed#4834.

Release Notes:

- N/A

### Some screenshots

Completion support
![CleanShot 2024-05-13 at 22 58
23@2x](https://github.com/zed-industries/zed/assets/1894248/d5047baa-c58f-465d-ae31-a7045aa56adf)

Symbol search
![CleanShot 2024-05-13 at 23 03
59@2x](https://github.com/zed-industries/zed/assets/1894248/0cb6320a-b000-4a0c-85eb-f8d1a8f6936e)

---------

Co-authored-by: Marshall Bowers <[email protected]>
notpeter pushed a commit to zed-extensions/ruby that referenced this pull request Oct 11, 2024
This PR bumps the Ruby extension to v0.0.2.

Changes:

- zed-industries/zed#11768

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shopify/ruby-lsp as an alternate language server
3 participants