Skip to content

[JENKINS-73687] Make deserialization of Map fields in XML files more robust #16527

@jenkins-infra-bot

Description

@jenkins-infra-bot

Accidental serial compatibility mistakes like the one described in jenkinsci/hashicorp-vault-plugin#326 should be limited in extent to the closest surrounding RobustFooConverter, which should report the warning to OldDataMonitor but otherwise ignore the broken element and continue deserialization normally.

In that issue, a mistake involving a Map field in a folder property lead to the folder itself being corrupted in a way that caused further problems, which we would like to avoid.

#9653 proposes a change to RobustMapConverter which would have limited the impact of this kind of mistake.


Originally reported by dnusbaum, imported from: Make deserialization of Map fields in XML files more robust
  • assignee: dnusbaum
  • status: Resolved
  • priority: Minor
  • component(s): core
  • resolution: Fixed
  • resolved: 2024-09-17T14:49:03+00:00
  • votes: 0
  • watchers: 1
  • imported: 2025-11-24
Raw content of original issue

Accidental serial compatibility mistakes like the one described in jenkinsci/hashicorp-vault-plugin#326 should be limited in extent to the closest surrounding RobustFooConverter, which should report the warning to OldDataMonitor but otherwise ignore the broken element and continue deserialization normally.

In that issue, a mistake involving a Map field in a folder property lead to the folder itself being corrupted in a way that caused further problems, which we would like to avoid.

#9653 proposes a change to RobustMapConverter which would have limited the impact of this kind of mistake.

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions