[FLINK-30020] Use separate Prometheus CollectorRegistries - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 1.17.0
Component/s: Runtime / Metrics
Labels:
- pull-request-available

Release Note:

Hide
The PrometheusReporters now use a separate CollectorRegistry for each reporter instance instead of the singleton default registry.
This generally shouldn't impact setups, but it may break code that indirectly interacted with the reporter via the singleton instance (e.g., a test trying to assert what metrics are reported).

Show
The PrometheusReporters now use a separate CollectorRegistry for each reporter instance instead of the singleton default registry. This generally shouldn't impact setups, but it may break code that indirectly interacted with the reporter via the singleton instance (e.g., a test trying to assert what metrics are reported).

Description

The PrometheusReporter uses the singleton collector registry, which means that defining multiple prometheus reporters with different metric filters will not behave as expected.

Attachments

Issue Links

links to

GitHub Pull Request #21317

Activity

People

Assignee:: Chesnay Schepler

Reporter:: Chesnay Schepler

Votes:: 0 Vote for this issue

Watchers:: 0 Start watching this issue

Dates

Created:: 14/Nov/22 09:17

Updated:: 14/Nov/22 18:08

Resolved:: 14/Nov/22 17:59