Rubyのコードレビューで軽く突っ込んだところ

def find_something
  ret = nil
  Foo.each do |item|
    if item.this_is_it?
      ret = item
      break
    end
  end
  ret
end

def find_something
  Foo.find{|item| item.this_is_it?}
end

def find_or_create info
  ret = find_something(info.id)
  ret = create_something(info) if ret.nil?
  ret
end

def find_or_create info
  find_something(info.id) || create_something(info)
end

str = ""
Items.each do |item|
  str += "#{item.key}='#{item.val}'"
end

str = Items.map do |item|
  "#{item.key}='#{item.val}'"
end.join

%w(1 0 2 5 0 2).map{|v| v.to_i}.select{|v| v>0}

%w(1 0 2 5 0 2).map(&:to_i).select(&:nonzero?)

%w(1 0 2 5 0 2).map(&:to_i).select(&:nonzero?)

%w(1 0 2 5 0 2).map(&:to_i).reject(&:zero?)