Skip to content

Ignore suppression when generating baseline #5887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

soyuka
Copy link
Contributor

@soyuka soyuka commented Jul 3, 2024

If an event is suppressed, while generating the baseline, we only checked for ignoreSuppressionOfPhpWarnings although we should check every option.

@sebastianbergmann sebastianbergmann added type/enhancement A new idea that should be implemented feature/test-runner CLI test runner labels Jul 3, 2024
@soyuka soyuka force-pushed the generate-deprecation-baseline branch 2 times, most recently from 82bbbf3 to 969f390 Compare July 13, 2024 08:03
Copy link

codecov bot commented Jul 13, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 94.07%. Comparing base (a8f4038) to head (d2e49f4).

Files Patch % Lines
src/Runner/Baseline/Generator.php 75.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               10.5    #5887      +/-   ##
============================================
+ Coverage     93.84%   94.07%   +0.23%     
- Complexity     6363     6571     +208     
============================================
  Files           677      699      +22     
  Lines         19286    19796     +510     
============================================
+ Hits          18099    18624     +525     
+ Misses         1187     1172      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soyuka soyuka force-pushed the generate-deprecation-baseline branch from 969f390 to b45f0cd Compare July 13, 2024 08:58
@soyuka
Copy link
Contributor Author

soyuka commented Jul 13, 2024

some of these lines are hard to cover, lmk if I need to do more

@nikophil
Copy link
Contributor

nikophil commented Jul 19, 2024

Hi!

💯 for this PR

I tried it and works perfectly.

Before the PR: vendor/bin/phpunit --generate-baseline tests/baseline.xml creates an empty file, whereas some deprecations are actually triggered. Those deprecations are created with the function trigger_deprecation() in symfony/deprecation-contracts, which uses @trigger_error().

After the PR, the baseline is fully created.

@sebastianbergmann sebastianbergmann force-pushed the generate-deprecation-baseline branch from b45f0cd to 81325a6 Compare July 19, 2024 15:22
@sebastianbergmann
Copy link
Owner

Please target the 10.5 branch. Thanks!

@soyuka soyuka force-pushed the generate-deprecation-baseline branch from 81325a6 to d2e49f4 Compare July 21, 2024 20:13
@soyuka soyuka changed the base branch from 11.2 to 10.5 July 21, 2024 20:13
@sebastianbergmann sebastianbergmann added version/10 Something affects PHPUnit 10 version/11 Something affects PHPUnit 11 type/bug Something is broken and removed type/enhancement A new idea that should be implemented labels Jul 22, 2024
@sebastianbergmann sebastianbergmann self-assigned this Jul 22, 2024
@sebastianbergmann sebastianbergmann merged commit fb17ba7 into sebastianbergmann:10.5 Jul 23, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/test-runner CLI test runner type/bug Something is broken version/10 Something affects PHPUnit 10 version/11 Something affects PHPUnit 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants