PMD / Issues / #1277 Delete BooleanInversion as it makes no sense

#1277 Delete BooleanInversion as it makes no sense

Milestone: PMD-5.3.0

Status: closed

Owner: Andreas Dangel

Labels: None

Module: PMD

Priority: 3-Major

Type: Bug

Affects version: 5.2.1

Ruleset / Rule:

Updated: 2015-04-01

Created: 2014-11-05

Creator: Vladimir Sitnikov

Private: No

As validated by JMH benchmark (see BooleanNegate Test Case), all the variants of boolean negation result in exactly the same machine code.
Thus it makes little sense to suggest one or the other way of expressing the code.

The issue is "reported" in https://twitter.com/shipilev/status/529975950411587584

1 Attachments

BooleanNegate.java

Discussion

Description has changed:

Diff:

--- old
+++ new
@@ -1,4 +1,4 @@
-As validated by JMH benchmark (see [1]), all the variants of boolean negation result in exactly the same machine code.
+As validated by JMH benchmark (see [BooleanNegate Test Case][1]), all the variants of boolean negation result in exactly the same machine code.
 Thus it makes little sense to suggest one or the other way of expressing the code.

 The issue is "reported" in https://twitter.com/shipilev/status/529975950411587584

status: open --> in-progress
assigned_to: Andreas Dangel
Milestone: New Tickets --> PMD-Next

Andreas Dangel - 2015-03-15

Thanks for pointing this out :)

The rule is deprecated now and will be removed with the release after 5.3.0.

The bytecode that is generated by the compiler is indeed different - but the JIT compiler seems to optimize it always to the "fastest way". So, there is no need anymore for this rule.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Andreas Dangel - 2015-03-15

status: in-progress --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Delete BooleanInversion as it makes no sense

A source code analyzer

Milestone

Searches

Help

#1277 Delete BooleanInversion as it makes no sense

Discussion