PMD / Issues / #1398 False positive for GuardLogStatementJavaUtil with Log4j

#1398 False positive for GuardLogStatementJavaUtil with Log4j

Milestone: PMD-5.3.4

Status: closed

Owner: Andreas Dangel

Labels: None

Module: PMD

Priority: 3-Major

Type: Bug

Affects version: 5.3.3

Ruleset / Rule: java-logging-java/GuardLogStatementJavaUtil

Updated: 2015-09-06

Created: 2015-08-31

Creator: Rei Angelus

Private: No

PMD detects a false positive GuardLogStatementJavaUtil with the code below :

    <test-code>
        <description>False positive for GuardLogStatementJavaUtil with Log4j</description>
        <expected-problems>0</expected-problems>
        <code><![CDATA[
import org.apache.log4j.Logger;

public class GuardLogTest {
    Logger LOG;
    public void foo() {
        if (LOG.isInfoEnabled()) {
            LOG.info("update: After spool map size: " + map.size());
        }
    }
}
        ]]></code>
    </test-code>

Thanks,

Discussion

Andreas Dangel - 2015-09-06

This will be fixed with PMD 5.3.4.

Commit: https://github.com/pmd/pmd/commit/100dd09b28931f57597355fb2cd5349bcbe10ab7

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Andreas Dangel - 2015-09-06

Description has changed:

Diff:

--- old +++ new @@ -1,7 +1,7 @@ PMD detects a false positive GuardLogStatementJavaUtil with the code below : -:::java - +~~~~~ +:::xml <test-code> <description>False positive for GuardLogStatementJavaUtil with Log4j</description> <expected-problems>0</expected-problems> @@ -18,5 +18,6 @@ } ]]></code> </test-code> +~~~~~ Thanks,

status: open --> closed

assigned_to: Andreas Dangel

Milestone: New Tickets --> PMD-5.3.4

Ruleset / Rule: --> java-logging-java/GuardLogStatementJavaUtil
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

False positive for GuardLogStatementJavaUtil with Log4j

A source code analyzer

Milestone

Searches

Help

#1398 False positive for GuardLogStatementJavaUtil with Log4j

Discussion