PMD / Issues / #1401 False positive for StringBuilder.append called with constructor

#1401 False positive for StringBuilder.append called with constructor

Milestone: PMD-5.3.4

Status: closed

Owner: Andreas Dangel

Labels: None

Module: PMD

Priority: 3-Major

Type: Bug

Affects version: 5.3.3

Ruleset / Rule: java/strings/ConsecutiveLiteralAppends

Updated: 2015-09-05

Created: 2015-09-04

Creator: Rei Angelus

Private: No

There is a false positive with the example below :

    <test-code>
        <description>False positive for StringBuilder.append called wtih constructor</description>
        <expected-problems>0</expected-problems>
        <code><![CDATA[
public class Foo {
    public String foo(final String value)
    {
        StringBuilder s = new StringBuilder("start:").append(value).append(":end");

        return s.toString();
    }
}
        ]]></code>
    </test-code>

Thanks,

Discussion

Description has changed:

Diff:

--- old
+++ new
@@ -1,7 +1,7 @@
 There is a false positive with the example below :

+~~~~~
 :::xml
-
     <test-code>
         <description>False positive for StringBuilder.append called wtih constructor</description>
         <expected-problems>0</expected-problems>
@@ -16,5 +16,6 @@
 }
         ]]></code>
     </test-code>
+~~~~~

 Thanks,

Andreas Dangel - 2015-09-05

Ruleset / Rule: --> java/strings/ConsecutiveLiteralAppends
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Andreas Dangel - 2015-09-05

summary: False positive for StringBuilder.append called wtih constructor --> False positive for StringBuilder.append called with constructor

status: open --> in-progress

assigned_to: Andreas Dangel

Milestone: New Tickets --> PMD-5.3.4
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Andreas Dangel - 2015-09-05

This will be fixed with PMD 5.3.4.

Commit: https://github.com/pmd/pmd/commit/58292bfc38d0a46d45f539c0dfd8e2a4d6f01558

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Andreas Dangel - 2015-09-05

status: in-progress --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

False positive for StringBuilder.append called with constructor

A source code analyzer

Milestone

Searches

Help

#1401 False positive for StringBuilder.append called with constructor

Discussion