PMD / Issues / #1403 False positive UnusedPrivateMethod with JAVA8

#1403 False positive UnusedPrivateMethod with JAVA8

Milestone: PMD-5.3.4

Status: closed

Owner: Andreas Dangel

Labels: None

Module: PMD

Priority: 3-Major

Type: Bug

Affects version:

Ruleset / Rule:

Updated: 2015-09-14

Created: 2015-09-11

Creator: Rei Angelus

Private: No

There is a false positive UnusedPrivateMethod with this kind of code :

public class Something {
    @Test public void mapMergeShouldReturnTheUnionWhenGivenDifferentSetsWithSomeCommonValues() {
        final Map<String, Purse> actual
                = Combiners.mapMerge(mapOf(annPurse5, bobPurse7), mapOf(bobPurse9, calPurse10), ADDITION);
        assertEquals(mapOf(annPurse5, bobPurse16, calPurse10), actual);
    }

    private static Map<String, Purse> mapOf(final Purse... values) {
        return mapOf(Purse::getOwner, values);
    }

    private static <K, V> Map<K, V> mapOf(final Function<V, K> keyMapper, final V... values) {
        return Stream.of(values).collect(Collectors.toMap(keyMapper, Function.identity()));
    }
}

Maybe because of Java 8 "mapOf(Purse::getOwner, values)" or private called by private ?

Thanks,

Discussion

Description has changed:

Diff:

--- old
+++ new
@@ -1,7 +1,7 @@
 There is a false positive UnusedPrivateMethod with this kind of code :

+~~~~~
 :::java
-
 public class Something {
    @Test public void mapMergeShouldReturnTheUnionWhenGivenDifferentSetsWithSomeCommonValues() {
         final Map<String, Purse> actual
@@ -17,6 +17,7 @@
         return Stream.of(values).collect(Collectors.toMap(keyMapper, Function.identity()));
     }
 }
+~~~~~

 Maybe because of Java 8 "mapOf(Purse::getOwner, values)" or private called by private ?

status: open --> closed
assigned_to: Andreas Dangel
Milestone: New Tickets --> PMD-5.3.4

Andreas Dangel - 2015-09-14

This will be fixed with PMD 5.3.4.

Commit: https://github.com/pmd/pmd/commit/2500412b147a31cef5940aba9ca0b504dd39003f

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

False positive UnusedPrivateMethod with JAVA8

A source code analyzer

Milestone

Searches

Help

#1403 False positive UnusedPrivateMethod with JAVA8

Discussion