PMD / Issues / #1424 [java] SimplifiedTernary: False positive with ternary operator

#1424 [java] SimplifiedTernary: False positive with ternary operator

Milestone: PMD-5.4.2

Status: closed

Owner: Andreas Dangel

Labels: java (55)

Module: PMD

Priority: 3-Major

Type: Bug

Affects version: 5.4.0

Ruleset / Rule: java-basic/SimplifiedTernary

Updated: 2016-06-25

Created: 2015-10-07

Creator: mingoto

Private: No

I get Ternary operators that can be simplified with || or && on this piece of code:

private SomeValue doStuff(SomeValue someValue) {
    return THE_VALUE.equals(rangeValue.to) ? new SomeValue(someValue.from, null, true) : someValue;
}

It works if I change to return THE_VALUE.equals(rangeValue.to) ? new SomeValue(someValue.from) : someValue;

Discussion

HairyFotr - 2015-12-04

False positive, not a false negative. I've seen this one too.

The XPath query matches any BooleanLiteral in the ternary subtrees - it should match just the literals directly (full AST path to literal): https://pmd.github.io/pmd-5.4.0/pmd-java/rules/java/basic.html#SimplifiedTernary

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Andreas Dangel - 2016-02-01

summary: False negative with ternary operator --> False positive with ternary operator

status: open --> closed

assigned_to: Andreas Dangel

Milestone: New Tickets --> PMD-5.4.2
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Andreas Dangel - 2016-02-01

This bug will be fixed with PMD 5.4.2 and later.

Commit: https://github.com/pmd/pmd/commit/cfaaf2f52ae791ed02347c1b8dbb1aa859435510

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Andreas Dangel - 2016-02-01

Ruleset / Rule: --> java-basic/SimplifiedTernary
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Andreas Dangel - 2016-06-25

labels: --> java

summary: False positive with ternary operator --> [java] SimplifiedTernary: False positive with ternary operator
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

[java] SimplifiedTernary: False positive with ternary operator

A source code analyzer

Milestone

Searches

Help

#1424 [java] SimplifiedTernary: False positive with ternary operator

Discussion