PMD / Issues / #1464 [java] UnnecessaryFinalModifier: false positive on a @SafeVarargs method

#1464 [java] UnnecessaryFinalModifier: false positive on a @SafeVarargs method

Milestone: PMD-5.3.7

Status: closed

Owner: Andreas Dangel

Labels: java (55)

Module: PMD

Priority: 3-Major

Type: Bug

Affects version: 5.3.5

Ruleset / Rule: UnnecessaryFinalModifier

Updated: 2016-06-25

Created: 2016-02-25

Creator: Alexey Yudichev

Private: No

It fails here. Removal of final modifier from a @SafeVarargs method breaks compilation, so this rule should ignore @SafeVarargs methods.

public final class InboxContents<T> {
    @SafeVarargs
    public final InboxContents<T> conflateWith(T... values) { // false positive
        return conflateWith(ImmutableList.copyOf(values));
    }
}

Discussion

Andreas Dangel - 2016-02-28

status: open --> closed

assigned_to: Andreas Dangel

Milestone: New Tickets --> PMD-5.3.7
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Andreas Dangel - 2016-02-28

This bug will be fixed with PMD 5.3.7 and later.

Commit: https://github.com/pmd/pmd/commit/573186be6900170948dba8fcbb0c520f5fd81aab

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Alexey Yudichev - 2016-02-29

I can see two 5.3 and 5.4 versions of PDM in the maven central. Will it be fixed in 5.4.2 too?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Andreas Dangel - 2016-02-29

Yes, the fix will be in all the next releases (5.3.7, 5.4.2 and 5.5.0). However, I don't know yet, when I'll release them.
If you need it right now, you can take the SNAPSHOT versions from the files download here:

https://sourceforge.net/projects/pmd/files/pmd/5.3.7-SNAPSHOT/

https://sourceforge.net/projects/pmd/files/pmd/5.4.2-SNAPSHOT/
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Andreas Dangel - 2016-06-25

labels: --> java

summary: UnnecessaryFinalModifier false positive on a @SafeVarargs method --> [java] UnnecessaryFinalModifier: false positive on a @SafeVarargs method
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

[java] UnnecessaryFinalModifier: false positive on a @SafeVarargs method

A source code analyzer

Milestone

Searches

Help

#1464 [java] UnnecessaryFinalModifier: false positive on a @SafeVarargs method

Discussion