PMD / Issues / #1476 [java] ArrayIsStoredDirectly: False positive

#1476 [java] ArrayIsStoredDirectly: False positive

Milestone: PMD-5.3.7

Status: closed

Owner: Andreas Dangel

Labels: java (55)

Module: PMD

Priority: 3-Major

Type: Bug

Affects version: 5.4.1

Ruleset / Rule: ArrayIsStoredDirectly

Updated: 2016-06-25

Created: 2016-04-28

Creator: Igor Melnichenko

Private: No

I have a constructor which creates a string from the specified byte array. It is considered as a violation by ArrayIsStoredDirectly.

public NotificationPacket(byte id, byte[] rawTypeData)
{
    super(id);

    if (rawTypeData == null)
    {
        throw new IllegalArgumentException("No type data is specified");
    }

    if (rawTypeData.length == 0)
    {
        this.message = EMPTY_MESSAGE;
    }
    else
    {
        this.message = new String(rawTypeData, StandardCharsets.UTF_8);
    }
}

Discussion

Andreas Dangel - 2016-04-30

status: open --> closed

assigned_to: Andreas Dangel

Milestone: New Tickets --> PMD-5.3.7
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Andreas Dangel - 2016-04-30

This will be fixed with PMD 5.3.7, 5.4.2 and 5.5.0.

Commit: https://github.com/pmd/pmd/commit/b9b0059797875a25c8caadffba0fcd2f6bf1f1c2

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Andreas Dangel - 2016-06-25

labels: --> java

summary: False positive of ArrayIsStoredDirectly --> [java] ArrayIsStoredDirectly: False positive
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

[java] ArrayIsStoredDirectly: False positive

A source code analyzer

Milestone

Searches

Help

#1476 [java] ArrayIsStoredDirectly: False positive

Discussion