PMD / Issues / #1496 [java] New Rule: AccesorMethodGeneration

#1496 [java] New Rule: AccesorMethodGeneration - complements accessor class rule

Milestone: PMD-5.5.4

Status: closed

Owner: Juan Sotuyo

Labels: java (55) java-design (7)

Module: PMD

Priority: 4-Minor

Type: Feature-Request

Affects version: 5.4.2

Ruleset / Rule:

Updated: 2017-02-13

Created: 2016-06-22

Creator: Jake Wharton

Private: No

The AccessorClassGeneration rule detects synthetic methods which are needed for accessing private constructors across nested class boundaries. Accessor methods are also generated when private methods or fields are accessed across nested class boundaries. I would like to see an AccessorMethodGeneration check added which detects where these would be generated so that they can be avoided in a similar fashion to the constructor ones.

Discussion

Jake Wharton - 2016-06-22

Also, complement. :facepalm:

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

labels: --> java, java-design
summary: Compliment accessor class rule with accessor method rule. --> [java] New Rule: AccesorMethodGeneration - complements accessor class rule
Description has changed:

Diff:

--- old
+++ new
@@ -1 +1 @@
-The `AccessorClassGeneration` rule detects synthetic methods which are needed for accessing private constructors across nested class boundaries. Accessor methods are also generated when private methods or fields are accessed across nested class boundaries. I would like to see an `AccessorMethodGeneration` check added which detects where these would be generated so that they can be avoided in a similar fashion to the constructor ones.
+The [AccessorClassGeneration](http://pmd.github.io/latest/pmd-java/rules/java/design.html#AccessorClassGeneration) rule detects synthetic methods which are needed for accessing private constructors across nested class boundaries. Accessor methods are also generated when private methods or fields are accessed across nested class boundaries. I would like to see an `AccessorMethodGeneration` check added which detects where these would be generated so that they can be avoided in a similar fashion to the constructor ones.

Juan Sotuyo - 2017-02-06

status: open --> in-progress

assigned_to: Juan Sotuyo
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Juan Sotuyo - 2017-02-06

I'll be tackling this. I'm very interested on helping Android developers keep away from multidex / 65k method count.

This rule will be specially awesome once we implement autofixable issues.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Andreas Dangel - 2017-02-13

status: in-progress --> closed

Milestone: New Tickets --> PMD-5.5.4
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Andreas Dangel - 2017-02-13

This rule will be available with PMD 5.5.4 and later.
See PR https://github.com/pmd/pmd/pull/244

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

[java] New Rule: AccesorMethodGeneration - complements accessor class rule

A source code analyzer

Milestone

Searches

Help

#1496 [java] New Rule: AccesorMethodGeneration - complements accessor class rule

Discussion