Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: google/error-prone
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.8.0
Choose a base ref
...
head repository: google/error-prone
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.8.1
Choose a head ref
  • 10 commits
  • 25 files changed
  • 4 contributors

Commits on Jul 22, 2021

  1. Remove removed tests from TEST_DEPS, and add assertions to prevent … 

    …recurrence.

PiperOrigin-RevId: 386240052
    @graememorgan
    graememorgan authored and Error Prone Team committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    91416d5 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2021

  1. Add suggested fixes for OptionalOfRedundantMethod 

    Flume hits: unknown commit

PiperOrigin-RevId: 386373157
    @java-team-github-bot
    java-team-github-bot authored and Error Prone Team committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    c5218ed View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. Add a flag to configure the default nullness annotation 

    PiperOrigin-RevId: 386953444
    @cushon
    cushon authored and Error Prone Team committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    de0b017 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2021

  1. Automatic code cleanup. 

    PiperOrigin-RevId: 386995333
    @cushon
    cushon authored and Error Prone Team committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    4e91cb4 View commit details
    Browse the repository at this point in the history

  2. Discourage looping over the result of toCharArray() 

    PiperOrigin-RevId: 387181359
    @cushon
    cushon authored and Error Prone Team committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    6a63b57 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2021

  1. All forEach on subtypes of Collection 

    `Collection` doesn't override the method from `Iterable`, but desugar
special-cases it to allow `forEach` to be called on collection subtypes.

PiperOrigin-RevId: 387858050
    @cushon
    cushon authored and Error Prone Team committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    4c57125 View commit details
    Browse the repository at this point in the history

  2. Fix typo in the "The Problem" paragraph. 

    PiperOrigin-RevId: 387904595
    @java-team-github-bot
    java-team-github-bot authored and Error Prone Team committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    cc5ef9e View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2021

  1. Handle more cases in ReturnMissingNullable. 

    I have no stats about how commonly these occur, but it's easy enough to handle them.

Also, minor cleanups and other notes:

- Document the `NullType` subtyping implementation trick.
- Check `returnType.isPrimitive()`, just as the old code used to. This check wasn't necessary in the new code until this CL's improvements.
- Inline `makeFix`, which doesn't really benefit from being a separate method. Then apply a suggested simplification.

PiperOrigin-RevId: 388295613
    @cpovirk
    cpovirk authored and Error Prone Team committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    b660308 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2021

  1. Use nexus-staging-maven-plugin to release to maven central from maven 

    PiperOrigin-RevId: 388506569
    @cushon
    cushon authored and Error Prone Team committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    fb208dd View commit details
    Browse the repository at this point in the history

  2. Release Error Prone 2.8.1

    @cushon
    cushon committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    3f51efd View commit details
    Browse the repository at this point in the history
Loading