Skip to content

feat: add graal-sdk dependency management to java-shared-config #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2023
Merged

feat: add graal-sdk dependency management to java-shared-config #683

merged 2 commits into from
Oct 12, 2023

Conversation

mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Oct 12, 2023 •
edited
Loading

Tested locally by removing graal-sdk version declaration from gax:

 <dependency>
        <groupId>org.graalvm.sdk</groupId>
        <artifactId>graal-sdk</artifactId>
        <version>${graal-sdk.version}</version>
      </dependency>

And calling mvn dependency:tree:

Screenshot 2023-10-11 at 4 32 55 PM

@mpeddada1 mpeddada1 requested a review from a team as a code owner October 12, 2023 16:04
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Oct 12, 2023
burkedavison
burkedavison reviewed Oct 12, 2023
View reviewed changes
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Oct 12, 2023
@mpeddada1 mpeddada1 merged commit 5cd1d84 into main Oct 12, 2023
@mpeddada1 mpeddada1 deleted the graal-dep-management branch October 12, 2023 17:57
@mpeddada1 mpeddada1 mentioned this pull request Oct 13, 2023
Merged
@release-please release-please bot mentioned this pull request Oct 16, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 17, 2023
@release-please
chore(main): release 1.6.0 (#687)
2449b48 
🤖 I have created a release *beep* *boop*
---


## [1.6.0](https://togithub.com/googleapis/java-shared-config/compare/v1.5.8...v1.6.0) (2023-10-17)


### Features

* Add graal-sdk dependency management to java-shared-config ([#683](https://togithub.com/googleapis/java-shared-config/issues/683)) ([5cd1d84](https://togithub.com/googleapis/java-shared-config/commit/5cd1d84bf2d68dbe8f9fa7e02d9065082bd56726))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burkedavison burkedavison burkedavison approved these changes

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpeddada1 @burkedavison