Skip to content

fix: use random table when loading data for read_csv, read_json, read_parquet #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 9, 2023
Merged

fix: use random table when loading data for read_csv, read_json, read_parquet #175

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
29fd315
fix: use random table when loading data for read_csv, read_json, read…
ashleyxuu Nov 6, 2023
a00d97f
Merge branch 'main' into b309108907-update-csv-parquet-json-table
ashleyxuu Nov 7, 2023
84fb2ea
Merge branch 'main' into b309108907-update-csv-parquet-json-table
ashleyxuu Nov 8, 2023
a7dafd3
Merge branch 'main' into b309108907-update-csv-parquet-json-table
tswast Nov 9, 2023
6136af7
Merge branch 'main' into b309108907-update-csv-parquet-json-table
ashleyxuu Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions bigframes/session/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,7 +806,7 @@ def _read_gbq_with_ordering(
def _read_bigquery_load_job(
self,
filepath_or_buffer: str | IO["bytes"],
table: bigquery.Table,
table: Union[bigquery.Table, bigquery.TableReference],
*,
job_config: bigquery.LoadJobConfig,
index_col: Iterable[str] | str = (),
Expand Down Expand Up @@ -1042,7 +1042,7 @@ def read_csv(
encoding: Optional[str] = None,
**kwargs,
) -> dataframe.DataFrame:
table = bigquery.Table(self._create_session_table())
table = bigframes_io.random_table(self._anonymous_dataset)

if engine is not None and engine == "bigquery":
if any(param is not None for param in (dtype, names)):
Expand Down Expand Up @@ -1156,7 +1156,7 @@ def read_parquet(
# Note: "engine" is omitted because it is redundant. Loading a table
# from a pandas DataFrame will just create another parquet file + load
# job anyway.
table = bigquery.Table(self._create_session_table())
table = bigframes_io.random_table(self._anonymous_dataset)

job_config = bigquery.LoadJobConfig()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We forgot to set the table expiration. I can follow-up with a PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#193

job_config.create_disposition = bigquery.CreateDisposition.CREATE_IF_NEEDED
Expand All @@ -1179,7 +1179,7 @@ def read_json(
engine: Literal["ujson", "pyarrow", "bigquery"] = "ujson",
**kwargs,
) -> dataframe.DataFrame:
table = bigquery.Table(self._create_session_table())
table = bigframes_io.random_table(self._anonymous_dataset)

if engine == "bigquery":

Expand Down