netty: implement UdsNameResolver and UdsNettyChannelProvider #9113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the scheme is "unix:" we get the UdsNettyChannelProvider to create a NettyChannelBuilder with DomainSocketAddress type and other related params needed for UDS sockets
ejona86
reviewed
Apr 28, 2022
and address review comments
|
Addressed comments and added an e2e test. PTAL |
ejona86
reviewed
Apr 29, 2022
netty/src/test/java/io/grpc/netty/UdsNettyChannelProviderTest.java
Outdated
Show resolved
Hide resolved
|
addressed the remaining comments. PTAL |
|
@sanjaypujare, push the changes? |
|
It has shown up now! |
The commit is there now: for some reason there was a delay which is really unusual. |
ejona86
reviewed
Apr 29, 2022
netty/src/test/java/io/grpc/netty/UdsNettyChannelProviderTest.java
Outdated
Show resolved
Hide resolved
ejona86
requested changes
May 2, 2022
ejona86
reviewed
May 2, 2022
ejona86
approved these changes
May 2, 2022
|
|
||
| @Test | ||
| public void basicMethods() { | ||
| assertTrue(provider.isAvailable()); |
There was a problem hiding this comment.
Yes, with the latest change made to UdsNettyChannelProvider it should be assumeTrue. Otherwise this was copied from NettyChannelProviderTest which used assertTrue . Good catch. Making the change
Fixed bazel build as well. PTAL |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the scheme is "unix:" we get the UdsNettyChannelProvider to
create a NettyChannelBuilder with DomainSocketAddress type and
other related params needed for UDS sockets
fixes #8884