Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: serde-rs/serde
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.144
Choose a base ref
...
head repository: serde-rs/serde
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.0.145
Choose a head ref
  • 10 commits
  • 13 files changed
  • 3 contributors

Commits on Aug 31, 2022

  1. Configuration menu
    Copy the full SHA
    a7f4551 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2022

  1. Update ci.yml

    Signed-off-by: sashashura <[email protected]>
    sashashura authored Sep 2, 2022
    Configuration menu
    Copy the full SHA
    68eb59d View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2273 from sashashura/patch-1

    GitHub Workflows security hardening
    dtolnay authored Sep 2, 2022
    Configuration menu
    Copy the full SHA
    5386897 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2022

  1. Command-line ignore let_underscore_drop clippy lint

    For whatever reason, the #![cfg_attr(feature = "cargo-clippy", allow(let_underscore_drop))]
    attributes already in the code stopped working in the most recent nightly (2022-09-03).
    Likely in connection with rust-lang/rust#97739 ?
    
        error: non-binding `let` on a type that implements `Drop`
           --> serde/src/de/mod.rs:958:13
            |
        958 |             let _ = visitor;
            |             ^^^^^^^^^^^^^^^^
            |
            = note: `-D clippy::let-underscore-drop` implied by `-D clippy::pedantic`
            = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop`
            = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop
    
        error: non-binding `let` on a type that implements `Drop`
           --> serde/src/de/mod.rs:992:13
            |
        992 |             let _ = visitor;
            |             ^^^^^^^^^^^^^^^^
            |
            = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop`
            = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop
    
        error: non-binding `let` on a type that implements `Drop`
            --> serde/src/de/mod.rs:1616:9
             |
        1616 |         let _ = deserializer;
             |         ^^^^^^^^^^^^^^^^^^^^^
             |
             = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop`
             = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop
    
        error: non-binding `let` on a type that implements `Drop`
            --> serde/src/de/mod.rs:1640:9
             |
        1640 |         let _ = deserializer;
             |         ^^^^^^^^^^^^^^^^^^^^^
             |
             = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop`
             = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop
    
        error: non-binding `let` on a type that implements `Drop`
            --> serde/src/de/mod.rs:1651:9
             |
        1651 |         let _ = seq;
             |         ^^^^^^^^^^^^
             |
             = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop`
             = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop
    
        error: non-binding `let` on a type that implements `Drop`
            --> serde/src/de/mod.rs:1662:9
             |
        1662 |         let _ = map;
             |         ^^^^^^^^^^^^
             |
             = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop`
             = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop
    
        error: non-binding `let` on a type that implements `Drop`
            --> serde/src/de/mod.rs:1673:9
             |
        1673 |         let _ = data;
             |         ^^^^^^^^^^^^^
             |
             = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop`
             = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop
    
        error: non-binding `let` on a type that implements `Drop`
            --> serde/src/private/de.rs:1440:13
             |
        1440 |             let _ = visitor;
             |             ^^^^^^^^^^^^^^^^
             |
             = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop`
             = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop
    
        error: non-binding `let` on a type that implements `Drop`
            --> serde/src/private/de.rs:2163:13
             |
        2163 |             let _ = visitor;
             |             ^^^^^^^^^^^^^^^^
             |
             = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop`
             = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop
    dtolnay committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    d208762 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. Consistently avoid '?' throughout serde crate

    This makes it easy to redefine a 'try' macro to compare compile-time
    between `$expr?` and `match $expr { Ok=>v, Err=>return }`.
    dtolnay committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    a9320db View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fa6ce42 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2281 from dtolnay/try

    Redefine `try` macro to omit From::from error conversion
    dtolnay authored Sep 22, 2022
    Configuration menu
    Copy the full SHA
    f0346ae View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    be3c37e View commit details
    Browse the repository at this point in the history
  5. Merge pull request #2282 from ChayimFriedman2/sized-mutex-refcell-rwlock

    Serialize unsized `RefCell`, `Mutex` and `RwLock`
    dtolnay authored Sep 22, 2022
    Configuration menu
    Copy the full SHA
    d99009f View commit details
    Browse the repository at this point in the history
  6. Release 1.0.145

    dtolnay committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    8c036ee View commit details
    Browse the repository at this point in the history
Loading