feat: add connectionId support for external data sources #776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #776 +/- ##
============================================
- Coverage 80.41% 80.39% -0.02%
- Complexity 1263 1265 +2
============================================
Files 79 79
Lines 6519 6525 +6
Branches 739 743 +4
============================================
+ Hits 5242 5246 +4
- Misses 888 889 +1
- Partials 389 390 +1
Continue to review full report at Codecov.
|
shollyman
approved these changes
Oct 1, 2020
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ExternalTableDefinition.java
Outdated
Show resolved
Hide resolved
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Oct 1, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [1.122.0](https://www.github.com/googleapis/java-bigquery/compare/v1.121.0...v1.122.0) (2020-10-01) ### Features * add connectionId support for external data sources ([#776](https://www.github.com/googleapis/java-bigquery/issues/776)) ([dcd7daa](https://www.github.com/googleapis/java-bigquery/commit/dcd7daa15d8f820affc9c155ba6d7a9a4c15066d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add connecitonId to ExternalTableDefinition to allow external data source query through the BigQuery client.