Skip to content
This repository was archived by the owner on Sep 27, 2023. It is now read-only.

Conversation

@yoshi-automation
Copy link
Contributor

PiperOrigin-RevId: 309415646

Source-Author: Google APIs <[email protected]>
Source-Date: Fri May 1 09:02:38 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: f78da0d54c78aa8f66d52a448db1f7ec0e0fd591
Source-Link: googleapis/googleapis@f78da0d
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 1, 2020
@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #165 into master will not change coverage.
The diff coverage is 83.68%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #165   +/-   ##
=========================================
  Coverage     71.41%   71.41%           
  Complexity      190      190           
=========================================
  Files             6        6           
  Lines          1847     1847           
  Branches          6        6           
=========================================
  Hits           1319     1319           
  Misses          489      489           
  Partials         39       39           
Impacted Files Coverage Δ Complexity Δ
...java/com/google/cloud/dlp/v2/DlpServiceClient.java 47.36% <ø> (ø) 103.00 <0.00> (ø)
...va/com/google/cloud/dlp/v2/DlpServiceSettings.java 7.52% <0.00%> (ø) 2.00 <0.00> (ø)
...a/com/google/cloud/dlp/v2/stub/DlpServiceStub.java 2.56% <0.00%> (ø) 1.00 <0.00> (ø)
...ogle/cloud/dlp/v2/stub/DlpServiceStubSettings.java 82.95% <82.79%> (ø) 42.00 <8.00> (ø)
...m/google/cloud/dlp/v2/stub/GrpcDlpServiceStub.java 98.06% <99.37%> (ø) 39.00 <12.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9da5fa1...8013618. Read the comment docs.

@noahdietz
Copy link

I diff'd the DlpServiceStubSettings.java changes in this PR against that of the commit preceding the offending commit and there is virtually no difference (just a one line comment change). Thus this should restore the retry settings properly.

The remaining diffs I believe are just from reordering of the generated code (gapic config order vs. proto order) and binary compatibility passes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants