Skip to content
This repository was archived by the owner on Sep 27, 2023. It is now read-only.

chore: load samples secrets better #476

Closed
wants to merge 4 commits into from
Closed

chore: load samples secrets better #476

wants to merge 4 commits into from

Conversation

@Neenu1995
Copy link
Contributor

@Neenu1995 Neenu1995 commented Mar 23, 2021

No description provided.

@product-auto-label product-auto-label bot added the api: dlp Issues related to the googleapis/java-dlp API. label Mar 23, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 23, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Mar 23, 2021
@codecov
Copy link

codecov bot commented Mar 23, 2021 •
edited
Loading

Codecov Report

Merging #476 (f2edd46) into master (e7e9ccd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #476   +/-   ##
=========================================
  Coverage     84.55%   84.55%           
  Complexity      310      310           
=========================================
  Files             6        6           
  Lines          1930     1930           
  Branches         52       52           
=========================================
  Hits           1632     1632           
  Misses          238      238           
  Partials         60       60

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7e9ccd...f2edd46. Read the comment docs.

@Neenu1995 Neenu1995 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 23, 2021
@chingor13 chingor13 marked this pull request as ready for review March 23, 2021 21:47
@chingor13 chingor13 requested a review from a team as a code owner March 23, 2021 21:47
chingor13
chingor13 suggested changes Mar 23, 2021
View reviewed changes
@Neenu1995 Neenu1995 closed this Mar 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@chingor13 chingor13 chingor13 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: dlp Issues related to the googleapis/java-dlp API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Neenu1995 @chingor13