Skip to content

fix: make TransportChannel autocloseable #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 8, 2020
Merged

fix: make TransportChannel autocloseable #212

merged 2 commits into from
Sep 8, 2020

Conversation

suraj-qlogic
Copy link
Contributor

Fixes #211

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 18, 2020
simonz130
simonz130 previously requested changes Aug 18, 2020
View reviewed changes
google-cloud-logging/src/main/java/com/google/cloud/logging/spi/v2/GrpcLoggingRpc.java
.setBackgroundResources(
Collections.<BackgroundResource>singletonList(transportChannel))
.build();
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is the catch block for this try?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@suraj-qlogic suraj-qlogic self-assigned this Aug 18, 2020
@suraj-qlogic suraj-qlogic requested a review from simonz130 August 18, 2020 06:11
@codecov
Copy link

codecov bot commented Aug 18, 2020 •
edited
Loading

Codecov Report

Merging #212 into master will decrease coverage by 0.03%.
The diff coverage is 84.61%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #212      +/-   ##
============================================
- Coverage     75.17%   75.14%   -0.04%     
  Complexity      593      593              
============================================
  Files            42       42              
  Lines          3646     3649       +3     
  Branches        251      251              
============================================
+ Hits           2741     2742       +1     
- Misses          757      759       +2     
  Partials        148      148
Impacted Files Coverage Δ Complexity Δ
...om/google/cloud/logging/spi/v2/GrpcLoggingRpc.java 42.47% <84.61%> (-0.25%) 1.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4f19e8...62d94ad. Read the comment docs.

@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Aug 21, 2020
@suraj-qlogic
Copy link
Contributor Author

@simonz130 ,PTAL

@chingor13 chingor13 merged commit e4853b1 into googleapis:master Sep 8, 2020
@suraj-qlogic suraj-qlogic deleted the java-logging-211 branch September 9, 2020 04:12
@gabriel-sada gabriel-sada mentioned this pull request Jul 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

@simonz130 simonz130 Awaiting requested review from simonz130

Assignees

@suraj-qlogic suraj-qlogic

Labels
api: logging Issues related to the googleapis/java-logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

java.lang.RuntimeException: ManagedChannel allocation site
3 participants
@suraj-qlogic @chingor13 @simonz130