-
Notifications
You must be signed in to change notification settings - Fork 39
feat: Makes remaining LogBucket and LogViews methods public #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiperOrigin-RevId: 342353190 Source-Author: Google APIs <[email protected]> Source-Date: Fri Nov 13 15:44:35 2020 -0800 Source-Repo: googleapis/googleapis Source-Sha: be0bdf86cd31aa7c1a7b30a9a2e9f2fd53ee3d91 Source-Link: googleapis/googleapis@be0bdf8
Warning: This pull request is touching the following templated files:
|
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
============================================
+ Coverage 75.85% 76.69% +0.84%
- Complexity 640 673 +33
============================================
Files 44 44
Lines 3876 4192 +316
Branches 281 282 +1
============================================
+ Hits 2940 3215 +275
- Misses 772 812 +40
- Partials 164 165 +1
Continue to review full report at Codecov.
|
simonz130
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: logging
Issues related to the googleapis/java-logging API.
cla: yes
This human has signed the Contributor License Agreement.
context: full
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated using Autosynth. 🌈
Synth log will be available here:
https://source.cloud.google.com/results/invocations/37d7837b-1bd3-4c03-9dca-513a772404ce/targets
PiperOrigin-RevId: 342353190
Source-Link: googleapis/googleapis@be0bdf8