test: SpannerRetryHelperTest is flaky #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

olavloite opened this issue May 13, 2020 · 0 comments · Fixed by #204

Assignees

Labels

api: spanner type: cleanup

Collaborator

olavloite commented May 13, 2020

On Windows/Java8 the following test failure sometimes occurs:

java.lang.AssertionError:

Expected: is <true>
     but: was <false>
	at com.google.cloud.spanner.SpannerRetryHelperTest.testExceptionWithRetryInfo(SpannerRetryHelperTest.java:219)

The text was updated successfully, but these errors were encountered:

olavloite added type: cleanup api: spanner labels

olavloite self-assigned this

olavloite added a commit that referenced this issue


          fix: use nanos to prevent truncation errors

1f0604b

SpannerRetryHelperTest.testExceptionWithRetryInfo could sometimes fail on some
environments. I have not been able to reproduce it locally, but one possible
reason for the failure could be truncation when converting from nanoseconds to
milliseconds. Now both the timeout and the verification use nanosecond precision.

This change also removes all uses of hamcres in this test file.

Fixes #200

olavloite mentioned this issue

fix: use nanos to prevent truncation errors #204

Merged

skuruppu closed this as completed in #204

skuruppu pushed a commit that referenced this issue


          fix: use nanos to prevent truncation errors (#204)

a608460

SpannerRetryHelperTest.testExceptionWithRetryInfo could sometimes fail on some
environments. I have not been able to reproduce it locally, but one possible
reason for the failure could be truncation when converting from nanoseconds to
milliseconds. Now both the timeout and the verification use nanosecond precision.

This change also removes all uses of hamcres in this test file.

Fixes #200

gcf-merge-on-green bot pushed a commit that referenced this issue


          chore: release 1.55.0 (#211)

2e533b7

🤖 I have created a release \*beep\* \*boop\* 
---
## [1.55.0](https://www.github.com/googleapis/java-spanner/compare/v1.54.0...v1.55.0) (2020-05-19)


### Features

* mark when a Spanner client is closed ([#198](https://www.github.com/googleapis/java-spanner/issues/198)) ([50cb174](https://www.github.com/googleapis/java-spanner/commit/50cb1744e7ede611758d3ff63b3df77a1d3682eb))


### Bug Fixes

* make it possible to override backups methods ([#195](https://www.github.com/googleapis/java-spanner/issues/195)) ([2d19c25](https://www.github.com/googleapis/java-spanner/commit/2d19c25ba32847d116194565e67e1b1276fcb9f8))
* Partitioned DML timeout was not always respected ([#203](https://www.github.com/googleapis/java-spanner/issues/203)) ([13cb37e](https://www.github.com/googleapis/java-spanner/commit/13cb37e55ddfd1ff4ec22b1dcdc20c4832eee444)), closes [#199](https://www.github.com/googleapis/java-spanner/issues/199)
* partitionedDml stub was not closed ([#213](https://www.github.com/googleapis/java-spanner/issues/213)) ([a2d9a33](https://www.github.com/googleapis/java-spanner/commit/a2d9a33fa31f7467fc2bfbef5a29c4b3f5aea7c8))
* reuse clientId for invalidated databases ([#206](https://www.github.com/googleapis/java-spanner/issues/206)) ([7b4490d](https://www.github.com/googleapis/java-spanner/commit/7b4490dfb61fbc81b5bd6be6c9a663b36b5ce402))
* use nanos to prevent truncation errors ([#204](https://www.github.com/googleapis/java-spanner/issues/204)) ([a608460](https://www.github.com/googleapis/java-spanner/commit/a60846043dc0ca47e1970d8ab99380b6d725c7a9)), closes [#200](https://www.github.com/googleapis/java-spanner/issues/200)


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.3.1 ([#190](https://www.github.com/googleapis/java-spanner/issues/190)) ([ad41a0d](https://www.github.com/googleapis/java-spanner/commit/ad41a0d4b0cc6a2c0ae0611c767652f64cfb2fb7))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).

ansh0l pushed a commit to ansh0l/java-spanner that referenced this issue


          regen (googleapis#200)

b8fbc68

rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this issue


          build(deps): update dependency org.apache.maven.plugins:maven-project…

cdc515e

…-info-reports-plugin to v3.1.1 (googleapis#200)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment