feat: add support for instance processing units #665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: This pull request is touching the following templated files:
|
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
skuruppu
approved these changes
Nov 25, 2020
|
Warning: This pull request is touching the following templated files:
|
elharo
suggested changes
Jan 21, 2021
|
Warning: This pull request is touching the following templated files:
|
Codecov Report
@@ Coverage Diff @@
## master #665 +/- ##
============================================
+ Coverage 84.86% 84.91% +0.04%
- Complexity 2762 2769 +7
============================================
Files 156 156
Lines 14318 14335 +17
Branches 1377 1379 +2
============================================
+ Hits 12151 12172 +21
+ Misses 1596 1592 -4
Partials 571 571
Continue to review full report at Codecov.
|
6269b7b to
6746435
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
6746435 to
6269b7b
Compare
6269b7b to
b4e4c39
Compare
f5569ef to
187c33c
Compare
Due to master merge the compilation was failing. Fixes the builder construction here.
Adds default implementation for the InstanceInfo set processing units in order to avoid a breaking change.
Removes the LCI samples for now, because they won't compile. We will re-add them once the main implementation is released.
b164d50 to
dc17892
Compare
elharo
reviewed
Jun 16, 2021
google-cloud-spanner/src/main/java/com/google/cloud/spanner/InstanceAdminClientImpl.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/InstanceInfo.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/InstanceInfo.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/InstanceInfo.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/InstanceAdminClientImplTest.java
Outdated
Show resolved
Hide resolved
elharo
approved these changes
Jun 18, 2021
ansh0l
pushed a commit
to ansh0l/java-spanner
that referenced
this pull request
Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will update the corresponding PR to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot will not create any more regeneration PRs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs once per night. If you have been assigned to review this PR, please: - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt genbot to assign reviewers to the google-cloud-go PR. Corresponding google-cloud-go PR: googleapis/google-cloud-go#4689 Changes: feat(gaming): support version reporting API PiperOrigin-RevId: 393476621 Source-Link: googleapis/googleapis@e9da6f8 chore: update gapic-generator-ruby to 0.10.1 Committer: @virost PiperOrigin-RevId: 393450219 Source-Link: googleapis/googleapis@41635ad
rajatbhatta
pushed a commit
to rajatbhatta/java-spanner
that referenced
this pull request
Nov 17, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.5.2](https://www.github.com/googleapis/java-spanner-jdbc/compare/v2.5.1...v2.5.2) (2021-11-11) ### Dependencies * update dependency com.google.cloud:google-cloud-spanner-bom to v6.15.2 ([googleapis#664](https://www.github.com/googleapis/java-spanner-jdbc/issues/664)) ([9f22c33](https://www.github.com/googleapis/java-spanner-jdbc/commit/9f22c331ee4c7340ed6f1b9f91a44ce1e4c5b792)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.