Skip to content
This repository was archived by the owner on Dec 31, 2023. It is now read-only.

docs(samples): Renaming region to avoid name collision with different… #167

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

m-strzelczyk
Copy link
Contributor

… region.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)

Fixes the fact that in pagination samples there is also a region called compute_images_list

@m-strzelczyk m-strzelczyk requested review from a team as code owners December 6, 2021 15:34
@snippet-bot
Copy link

snippet-bot bot commented Dec 6, 2021

Here is the summary of changes.

You are about to add 2 region tags.
You are about to delete 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 6, 2021
@product-auto-label product-auto-label bot added api: compute Issues related to the googleapis/python-compute API. samples Issues that are directly related to samples. labels Dec 6, 2021
@m-strzelczyk m-strzelczyk merged commit 60f2937 into main Dec 6, 2021
@m-strzelczyk m-strzelczyk deleted the deduplicate-regions branch December 6, 2021 17:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: compute Issues related to the googleapis/python-compute API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants