fix: correctly classify select statements that begin with brackets (#351)

larkee · web-flow · commit d526acca4795 · 2021-05-19T19:40:12.000+10:00
Co-authored-by: larkee &lt;larkee@users.noreply.github.com&gt;
diff --git a/google/cloud/spanner_dbapi/parse_utils.py b/google/cloud/spanner_dbapi/parse_utils.py
@@ -145,7 +145,7 @@
 STMT_INSERT = "INSERT"
 
 # Heuristic for identifying statements that don't need to be run as updates.
-RE_NON_UPDATE = re.compile(r"^\s*(SELECT)", re.IGNORECASE)
+RE_NON_UPDATE = re.compile(r"^\W*(SELECT)", re.IGNORECASE)
 
 RE_WITH = re.compile(r"^\s*(WITH)", re.IGNORECASE)
 
diff --git a/tests/unit/spanner_dbapi/test_parse_utils.py b/tests/unit/spanner_dbapi/test_parse_utils.py
@@ -33,6 +33,7 @@ def test_classify_stmt(self):
         cases = (
             ("SELECT 1", STMT_NON_UPDATING),
             ("SELECT s.SongName FROM Songs AS s", STMT_NON_UPDATING),
+            ("(SELECT s.SongName FROM Songs AS s)", STMT_NON_UPDATING),
             (
                 "WITH sq AS (SELECT SchoolID FROM Roster) SELECT * from sq",
                 STMT_NON_UPDATING,

Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,7 @@ def test_classify_stmt(self):`
`33`	`33`	`cases = (`
`34`	`34`	`("SELECT 1", STMT_NON_UPDATING),`
`35`	`35`	`("SELECT s.SongName FROM Songs AS s", STMT_NON_UPDATING),`
	`36`	`+ ("(SELECT s.SongName FROM Songs AS s)", STMT_NON_UPDATING),`
`36`	`37`	`(`
`37`	`38`	`"WITH sq AS (SELECT SchoolID FROM Roster) SELECT * from sq",`
`38`	`39`	`STMT_NON_UPDATING,`