Skip to content

Conversation

@larkee
Copy link
Contributor

@larkee larkee commented Jun 4, 2020

This PR fixes the links to other documentation, updates wording and fixes typos and grammar for docs/snapshot-usage.rst.

@larkee larkee requested review from hengfengli and skuruppu June 4, 2020 09:46
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 4, 2020
Copy link

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just wonder if there is any limit for line length in rst. I notice that on Line 89-92, the line length is quite different from previous lines.

@larkee
Copy link
Contributor Author

larkee commented Jun 4, 2020

LGTM. I just wonder if there is any limit for line length in rst. I notice that on Line 89-92, the line length is quite different from previous lines.

I believe that the query has been split like that to make it easier to understand rather than due to a line length limit.

@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 5, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 5, 2020
@larkee larkee merged commit 613d9c8 into googleapis:master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants