I don't believe that is correct.
Try this out using your patch:
<?php
echo duration( mktime(0, 0, 0, 1, 0, 2006)-time() );
?>
As of right now, this will read:
1 month, 22 days, 24 hours, 49 minutes, 15 seconds
Which is completely incorrect. Seeing as how it is the 9th of December.
The real real flaw here is how the 'year' and 'month' periods are calculated. As most months vary in length...
Thank you very much SnakeEater251 for pointing this out.
The quickest way to get slightly more accurate results, is to use averages based on one "true" year, which is 365.25 days.
Change the year and month to:
'year' => 31557600, // one 'true year' (365.25 days)
'month' => 2629800, // one 'true year' divided by 12 :-)
I will work on developing a true fix, for pin-point accuracy. ;-)
- Cory Christison