Very small patch for decode.c

Lists: pgsql-hackers
From: Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Very small patch for decode.c
Date: 2016-03-30 19:34:31
Message-ID: 56FC2A47.6020302@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

diff --git a/src/backend/replication/logical/decode.c b/src/backend/replication/logical/decode.c
index 2380ea2..a992662 100644
--- a/src/backend/replication/logical/decode.c
+++ b/src/backend/replication/logical/decode.c
@@ -488,7 +488,7 @@ DecodeCommit(LogicalDecodingContext *ctx, XLogRecordBuffer *buf,
{
XLogRecPtr origin_lsn = InvalidXLogRecPtr;
TimestampTz commit_time = parsed->xact_time;
- XLogRecPtr origin_id = XLogRecGetOrigin(buf->record);
+ RepOriginId origin_id = XLogRecGetOrigin(buf->record);
int i;

--
Konstantin Knizhnik
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Very small patch for decode.c
Date: 2016-03-31 00:43:50
Message-ID: CAB7nPqRJYC0kJtwKY0CjNX-zUgXjc7zLDGOGv5aatUUnJJxeJg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Thu, Mar 31, 2016 at 4:34 AM, Konstantin Knizhnik
<k(dot)knizhnik(at)postgrespro(dot)ru> wrote:
> diff --git a/src/backend/replication/logical/decode.c
> b/src/backend/replication/logical/decode.c
> index 2380ea2..a992662 100644
> --- a/src/backend/replication/logical/decode.c
> +++ b/src/backend/replication/logical/decode.c
> @@ -488,7 +488,7 @@ DecodeCommit(LogicalDecodingContext *ctx,
> XLogRecordBuffer *buf,
> {
> XLogRecPtr origin_lsn = InvalidXLogRecPtr;
> TimestampTz commit_time = parsed->xact_time;
> - XLogRecPtr origin_id = XLogRecGetOrigin(buf->record);
> + RepOriginId origin_id = XLogRecGetOrigin(buf->record);
> int i;

Good catch!
--
Michael

From: Craig Ringer <craig(at)2ndquadrant(dot)com>
To: Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Very small patch for decode.c
Date: 2016-03-31 00:54:39
Message-ID: CAMsr+YE+fMGUWfva1Mb2p2jK+b4vJy4gp323q_j7KkSMU+S=Lw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 31 March 2016 at 03:34, Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>
wrote:

> diff --git a/src/backend/replication/logical/decode.c
> b/src/backend/replication/logical/decode.c
> index 2380ea2..a992662 100644
> --- a/src/backend/replication/logical/decode.c
> +++ b/src/backend/replication/logical/decode.c
> @@ -488,7 +488,7 @@ DecodeCommit(LogicalDecodingContext *ctx,
> XLogRecordBuffer *buf,
> {
> XLogRecPtr origin_lsn = InvalidXLogRecPtr;
> TimestampTz commit_time = parsed->xact_time;
> - XLogRecPtr origin_id = XLogRecGetOrigin(buf->record);
> + RepOriginId origin_id = XLogRecGetOrigin(buf->record);
> int i;
>

Even though it's trivial, created as
https://commitfest.postgresql.org/10/594/ so we don't lose it.

--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Very small patch for decode.c
Date: 2016-03-31 02:44:00
Message-ID: 20160331024400.GA90848@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Konstantin Knizhnik wrote:
> diff --git a/src/backend/replication/logical/decode.c b/src/backend/replication/logical/decode.c
> index 2380ea2..a992662 100644
> --- a/src/backend/replication/logical/decode.c
> +++ b/src/backend/replication/logical/decode.c
> @@ -488,7 +488,7 @@ DecodeCommit(LogicalDecodingContext *ctx, XLogRecordBuffer *buf,
> {
> XLogRecPtr origin_lsn = InvalidXLogRecPtr;
> TimestampTz commit_time = parsed->xact_time;
> - XLogRecPtr origin_id = XLogRecGetOrigin(buf->record);
> + RepOriginId origin_id = XLogRecGetOrigin(buf->record);
> int i;

Pushed, thanks.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

From: Andres Freund <andres(at)anarazel(dot)de>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Very small patch for decode.c
Date: 2016-03-31 08:10:57
Message-ID: 20160331081057.GK13305@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2016-03-30 23:44:00 -0300, Alvaro Herrera wrote:
> Konstantin Knizhnik wrote:
> > diff --git a/src/backend/replication/logical/decode.c b/src/backend/replication/logical/decode.c
> > index 2380ea2..a992662 100644
> > --- a/src/backend/replication/logical/decode.c
> > +++ b/src/backend/replication/logical/decode.c
> > @@ -488,7 +488,7 @@ DecodeCommit(LogicalDecodingContext *ctx, XLogRecordBuffer *buf,
> > {
> > XLogRecPtr origin_lsn = InvalidXLogRecPtr;
> > TimestampTz commit_time = parsed->xact_time;
> > - XLogRecPtr origin_id = XLogRecGetOrigin(buf->record);
> > + RepOriginId origin_id = XLogRecGetOrigin(buf->record);
> > int i;
>
> Pushed, thanks.

Thanks for finding Konstantin, and pushing Alvaro.