| Lists: | pgsql-hackers |
|---|
| From: | "Wang, Shenhao" <wangsh(dot)fnst(at)cn(dot)fujitsu(dot)com> |
|---|---|
| To: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | [PATCH] Tab completion for CREATE OR REPLACE |
| Date: | 2019-08-22 06:05:44 |
| Message-ID: | 63580B24E208E3429D94153A03C68E0901AA8002D5@G08CNEXMBPEKD02.g08.fujitsu.local |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hello, hackers:
I created a patch about tab completion for command CREATE OR REPLACE in psql
includes:
CREATE [ OR REPLACE ] FUNCTION
CREATE [ OR REPLACE ] PROCEDURE
CREATE [ OR REPLACE ] LANGUAGE
CREATE [ OR REPLACE ] RULE name AS ON event
CREATE [ OR REPLACE ] VIEW AS SELECT
CREATE [ OR REPLACE ] AGGREGATE
CREATE [ OR REPLACE ] TRANSFORM
------------------------------------------------------------------------------------------
Regards
Shenhao Wang
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Tab-completion-of-CREATE-OR-REPLACE-in-psql.patch | application/octet-stream | 4.2 KB |
| From: | Ian Barwick <ian(dot)barwick(at)2ndquadrant(dot)com> |
|---|---|
| To: | "Wang, Shenhao" <wangsh(dot)fnst(at)cn(dot)fujitsu(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Tab completion for CREATE OR REPLACE |
| Date: | 2019-08-22 06:28:19 |
| Message-ID: | CABvVfJW2c=-N4FB95rc-6YQ05=t8bZi4r2QbMFGVax27PY1pAg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Thu, 22 Aug 2019 at 15:05, Wang, Shenhao <wangsh(dot)fnst(at)cn(dot)fujitsu(dot)com> wrote:
>
> Hello, hackers:
>
> I created a patch about tab completion for command CREATE OR REPLACE in psql
> includes:
> CREATE [ OR REPLACE ] FUNCTION
> CREATE [ OR REPLACE ] PROCEDURE
> CREATE [ OR REPLACE ] LANGUAGE
> CREATE [ OR REPLACE ] RULE name AS ON event
> CREATE [ OR REPLACE ] VIEW AS SELECT
> CREATE [ OR REPLACE ] AGGREGATE
> CREATE [ OR REPLACE ] TRANSFORM
>
> ------------------------------------------------------------------------------------------
Could you add this to the next commitfest?
https://commitfest.postgresql.org/24/
Regards
Ian Barwick
--
Ian Barwick https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | "Wang, Shenhao" <wangsh(dot)fnst(at)cn(dot)fujitsu(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Tab completion for CREATE OR REPLACE |
| Date: | 2019-09-03 14:04:49 |
| Message-ID: | CAHGQGwE3uVyJpFHiE7qDPLUuXmCWjLwo14o1s=Af1JQjkGkyEA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Thu, Aug 22, 2019 at 3:06 PM Wang, Shenhao
<wangsh(dot)fnst(at)cn(dot)fujitsu(dot)com> wrote:
>
> Hello, hackers:
>
> I created a patch about tab completion for command CREATE OR REPLACE in psql
> includes:
> CREATE [ OR REPLACE ] FUNCTION
> CREATE [ OR REPLACE ] PROCEDURE
> CREATE [ OR REPLACE ] LANGUAGE
> CREATE [ OR REPLACE ] RULE name AS ON event
> CREATE [ OR REPLACE ] VIEW AS SELECT
> CREATE [ OR REPLACE ] AGGREGATE
> CREATE [ OR REPLACE ] TRANSFORM
Thanks for the patch! The patch looks good to me.
Barring no objection, I will commit this.
Regards,
--
Fujii Masao
| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | "Wang, Shenhao" <wangsh(dot)fnst(at)cn(dot)fujitsu(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Tab completion for CREATE OR REPLACE |
| Date: | 2019-09-13 09:21:59 |
| Message-ID: | CAHGQGwGD6tNJ9by4kROKd3ZGnD7yqEmEQyZe=tufJ1M=ex1mgw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Tue, Sep 3, 2019 at 11:04 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Thu, Aug 22, 2019 at 3:06 PM Wang, Shenhao
> <wangsh(dot)fnst(at)cn(dot)fujitsu(dot)com> wrote:
> >
> > Hello, hackers:
> >
> > I created a patch about tab completion for command CREATE OR REPLACE in psql
> > includes:
> > CREATE [ OR REPLACE ] FUNCTION
> > CREATE [ OR REPLACE ] PROCEDURE
> > CREATE [ OR REPLACE ] LANGUAGE
> > CREATE [ OR REPLACE ] RULE name AS ON event
> > CREATE [ OR REPLACE ] VIEW AS SELECT
> > CREATE [ OR REPLACE ] AGGREGATE
> > CREATE [ OR REPLACE ] TRANSFORM
>
> Thanks for the patch! The patch looks good to me.
Committed. Thanks!
Regards,
--
Fujii Masao