Using pg_ctl promote -w in TAP tests

Lists: pgsql-hackers
From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Using pg_ctl promote -w in TAP tests
Date: 2016-10-10 12:37:37
Message-ID: CAB7nPqQOz2Cef7k-hQ6A4DQ+kjty0fs0rmj8L48FDJk_OBgv_w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi all,

Now that we have support for the wait mode of pg_ctl promote, I think
that it would be a good idea to switch to it in the TAP tests. This
allows avoiding extra logic with poll_query_until() to be sure that a
promoted standby is ready for read-write queries.
See the patch attached.

Thanks,
--
Michael

Attachment Content-Type Size
tap-promote-wait.patch text/x-diff 2.3 KB

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Using pg_ctl promote -w in TAP tests
Date: 2016-10-19 13:21:31
Message-ID: [email protected]
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 10/10/16 8:37 AM, Michael Paquier wrote:
> Now that we have support for the wait mode of pg_ctl promote, I think
> that it would be a good idea to switch to it in the TAP tests. This
> allows avoiding extra logic with poll_query_until() to be sure that a
> promoted standby is ready for read-write queries.
> See the patch attached.

committed

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services