Binary I/O for isn extension

Hi.

Attached is a small patch which adds binary input/output for the types
added by the isn extension.

Shay

Hi,

Thanks for the patch, you can add it to our commitfest app so it gets
reviewed in the next commitfest.

https://commitfest.postgresql.org/

A suggestion to make it easier for your patch to be accepted:

When adding new functions to an extension you need to bump the version
of the extension by renaming the file, updating the .control file,
creating an upgrade script, and updating the Makefile to include the new
files.

Andreas

Hello,

> Attached is a small patch which adds binary input/output for the types
> added by the isn extension.

I added this patch to the next CF (2016-09) under "Miscellaneous".

Out of curiosity, what is the motivation?

--
Fabien.

>
> When adding new functions to an extension you need to bump the version of
> the extension by renaming the file, updating the .control file, creating an
> upgrade script, and updating the Makefile to include the new files.

Thanks for the guidance, I'll fix all that and resubmit a patch.

> Thanks for the patch, you can add it to our commitfest app so it gets
> reviewed in the next commitfest.

I did this.

> A suggestion to make it easier for your patch to be accepted:
>
> When adding new functions to an extension you need to bump the version of the
> extension by renaming the file, updating the .control file, creating an
> upgrade script, and updating the Makefile to include the new files.

Indeed.

Moreover I'm not sure that a type may me updated incrementaly to add new
send/receive functions.

--
Fabien.

>
> I added this patch to the next CF (2016-09) under "Miscellaneous".
>

Thanks!

> Out of curiosity, what is the motivation?

I'm the owner of Npgsql, the open-source .NET driver for PostgreSQL, which
is a binary-first driver. That is, working with types that have no binary
I/O is possible but awkward.

I hope the general direction is (or will be) to have binary I/O for all
supported types, both for compatibility with binary-first consumers such as
Npgsql and for general efficiency.

>
> When adding new functions to an extension you need to bump the version of
> the extension by renaming the file, updating the .control file, creating an
> upgrade script, and updating the Makefile to include the new files.

Attached is a new version of the patch, adding an upgrade script and the
rest of it. Note that because, as Fabien noted, there's doesn't seem to be
a way to add send/receive functions with ALTER TYPE, I did that by updating
pg_type directly - hope that's OK.

Hello Shay,

> Attached is a new version of the patch, adding an upgrade script and the
> rest of it. Note that because, as Fabien noted, there's doesn't seem to be
> a way to add send/receive functions with ALTER TYPE, I did that by updating
> pg_type directly - hope that's OK.

This patch does not apply anymore, because there as been an update in
between to mark relevant contrib functions as "parallel".

Could you update the patch?

--
Fabien.

On Mon, Aug 22, 2016 at 8:14 AM, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
> Hello Shay,
>> Attached is a new version of the patch, adding an upgrade script and the
>> rest of it. Note that because, as Fabien noted, there's doesn't seem to be
>> a way to add send/receive functions with ALTER TYPE, I did that by
>> updating
>> pg_type directly - hope that's OK.
>
> This patch does not apply anymore, because there as been an update in
> between to mark relevant contrib functions as "parallel".
>
> Could you update the patch?

So, it's been over a month since this request, and there doesn't seem
to be an update to this patch. The CommitFest is over in 2 days, so
I've marked this "Returned with Feedback". Shay, please feel free to
resubmit for the next CommitFest.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Sorry about this, I just haven't had a free moment (and it's definitely not
very high priority...)

On Wed, Sep 28, 2016 at 5:04 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Mon, Aug 22, 2016 at 8:14 AM, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
> wrote:
> > Hello Shay,
> >> Attached is a new version of the patch, adding an upgrade script and the
> >> rest of it. Note that because, as Fabien noted, there's doesn't seem to
> be
> >> a way to add send/receive functions with ALTER TYPE, I did that by
> >> updating
> >> pg_type directly - hope that's OK.
> >
> > This patch does not apply anymore, because there as been an update in
> > between to mark relevant contrib functions as "parallel".
> >
> > Could you update the patch?
>
> So, it's been over a month since this request, and there doesn't seem
> to be an update to this patch. The CommitFest is over in 2 days, so
> I've marked this "Returned with Feedback". Shay, please feel free to
> resubmit for the next CommitFest.
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

On Wed, Sep 28, 2016 at 2:05 PM, Shay Rojansky <roji(at)roji(dot)org> wrote:
> Sorry about this, I just haven't had a free moment (and it's definitely not
> very high priority...)

No issues, just cleaning house.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company