| Lists: | pgsql-hackers |
|---|
| From: | Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | [PATCH] Cross-reference comments on signal handling logic |
| Date: | 2021-01-18 07:51:30 |
| Message-ID: | CAGRY4nyftC0tVyceYyDfQD2FXg6KVUvpVKGe_eXZK8OYwgrbRQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi all
The attached comments-only patch expands the signal handling section in
miscadmin.h a bit so that it mentions ProcSignal, deferred signal handling
during blocking calls, etc. It adds cross-refs between major signal
handling routines and the miscadmin comment to help readers track the
various scattered but inter-related code.
I hope this helps some new developers in future.
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Comments-and-cross-references-for-signal-handling.patch | text/x-patch | 11.6 KB |
| From: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
|---|---|
| To: | Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Cross-reference comments on signal handling logic |
| Date: | 2021-03-01 18:22:35 |
| Message-ID: | [email protected] |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
> On Jan 17, 2021, at 11:51 PM, Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com> wrote:
>
> <v1-0001-Comments-and-cross-references-for-signal-handling.patch>
In src/backend/postmaster/interrupt.c:
+ * These handlers are NOT used by normal user backends as they do not support
vs.
+ * Most backends use this handler.
These two comments seem to contradict. If interrupt.c contains handlers that normal user backends to not use, then how can it be that most backends use one of the handlers in the file?
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
| Subject: | Re: [PATCH] Cross-reference comments on signal handling logic |
| Date: | 2021-09-27 12:21:39 |
| Message-ID: | [email protected] |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
> On 1 Mar 2021, at 19:22, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> wrote:
>> On Jan 17, 2021, at 11:51 PM, Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com> wrote:
>>
>> <v1-0001-Comments-and-cross-references-for-signal-handling.patch>
>
> In src/backend/postmaster/interrupt.c:
>
> + * These handlers are NOT used by normal user backends as they do not support
>
> vs.
>
> + * Most backends use this handler.
>
> These two comments seem to contradict. If interrupt.c contains handlers that normal user backends to not use, then how can it be that most backends use one of the handlers in the file?
I'm closing this as Returned with Feedback as it there has been no response to
the review comment during two commitfests. Please reopen in a future
commitfest if you still would like to pursue this patch.
--
Daniel Gustafsson https://vmware.com/