| Lists: | pgsql-hackers |
|---|
| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Remove one last occurrence of "replication slave" in comments |
| Date: | 2019-06-19 12:35:02 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
A Twitter thread today regarding the use of master/slave [1] made me curious
and so I had a look. It seems that commit a1ef920e27ba6ab3602aaf6d6751d8628
replaced most instances but missed at least one which is fixed in the attached.
cheers ./daniel
[1] https://twitter.com/Xof/status/1141040942645776384
| Attachment | Content-Type | Size |
|---|---|---|
| slave_comment.patch | application/octet-stream | 1.0 KB |
| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove one last occurrence of "replication slave" in comments |
| Date: | 2019-06-19 12:39:24 |
| Message-ID: | CABUevEyoc767_B=gRFuR2gU4hjDxP6YhK89KsRxbPaehv692_g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Jun 19, 2019 at 2:35 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> A Twitter thread today regarding the use of master/slave [1] made me
> curious
> and so I had a look. It seems that commit
> a1ef920e27ba6ab3602aaf6d6751d8628
> replaced most instances but missed at least one which is fixed in the
> attached.
>
Applied, thanks.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
| From: | ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker ) |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove one last occurrence of "replication slave" in comments |
| Date: | 2019-06-19 17:04:27 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> A Twitter thread today regarding the use of master/slave [1] made me curious
> and so I had a look. It seems that commit a1ef920e27ba6ab3602aaf6d6751d8628
> replaced most instances but missed at least one which is fixed in the attached.
>
> cheers ./daniel
There were some more master/slave references in the plpgsql foreign key
tests, which the attached chages to base/leaf instead.
I didn't touch the last mention of "slave", in the pltcl code, because
it's calling the Tcl_CreateSlave() API function.
- ilmari
--
"The surreality of the universe tends towards a maximum" -- Skud's Law
"Never formulate a law or axiom that you're not prepared to live with
the consequences of." -- Skud's Meta-Law
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Remove-master-slave-usage-from-plpgsql-tests.patch | text/x-diff | 3.6 KB |
| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove one last occurrence of "replication slave" in comments |
| Date: | 2019-08-21 10:06:21 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 2019-06-19 19:04, Dagfinn Ilmari Mannsåker wrote:
> There were some more master/slave references in the plpgsql foreign key
> tests, which the attached chages to base/leaf instead.
base/leaf doesn't sound like a good pair. I committed it with root/leaf
instead.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From: | ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker ) |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove one last occurrence of "replication slave" in comments |
| Date: | 2019-08-21 13:54:25 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 2019-06-19 19:04, Dagfinn Ilmari Mannsåker wrote:
>> There were some more master/slave references in the plpgsql foreign key
>> tests, which the attached chages to base/leaf instead.
>
> base/leaf doesn't sound like a good pair. I committed it with root/leaf
> instead.
Thanks! You're right, that is a better name pair.
- ilmari
--
"A disappointingly low fraction of the human race is,
at any given time, on fire." - Stig Sandbeck Mathisen