Scribd
Upload
17 views3 pages

Harini Review Comments

The document lists various comments and statuses related to code reviews for multiple TypeScript files. It highlights issues such as extra empty lines, deprecated methods, and the need for constants instead of hard-coded values. All comments are currently marked as 'open' for further action or resolution.

Uploaded by

harini
Copyright
© © All Rights Reserved
We take content rights seriously. If you suspect this is your content, claim it here.
Available Formats
Download as XLSX, PDF, TXT or read online on Scribd
17 views3 pages

Harini Review Comments

The document lists various comments and statuses related to code reviews for multiple TypeScript files. It highlights issues such as extra empty lines, deprecated methods, and the need for constants instead of hard-coded values. All comments are currently marked as 'open' for further action or resolution.

Uploaded by

harini
Copyright
© © All Rights Reserved
We take content rights seriously. If you suspect this is your content, claim it here.
Available Formats
Download as XLSX, PDF, TXT or read online on Scribd
You are on page 1/ 3

387

Comment Status

authorized-grid.ts
extra empty line at 6 open
authorized-grid.spec.ts
extra empty line at 189, 192

open

388
Comment Status

authorized-model.spec.ts
extra empty line at 48
open
cover the case for hasPermission
return value false
open

352
Comment Status

invalid-estimated-work-service.ts
Line 21: Add api.constants.ts
under constants folder. Add
constant for api path and use it open
Line 43: Why parameters
queryByKey are different from
original app/services/model-
analysis/invalid-estimated-work-
service.ts open

invalid-estimated-work-
service.spec.ts
extra empty lines at line 12,102 open

345
Comment Status

http-interceptor-service.spec.ts
line 15 HttpClientTestingModule
is deprecated, instead add
provideHttpClientTesting() in
providers open
Line 38: mock localstorage.get
instead of setting token value to
storage open

Line 57, 69: subscribe is


deprecated. use next: and error: open

341
Comment Status

authorization-service.ts
Line 20 Add routes.constants.ts
and move unauthorizedRoute to
constant and use it open
authorization-service.spec.ts
Line 73 Use route constant for
unauthorizedRoute open

340
Comment Status
authentication-service.ts
Line 49, 71 use api.constants.ts
instead of hard coded api aths
open
Line 51-53 and 73-75 are
duplicate. move the code to
separate method and reuse open
authentication-service.spec.ts
Line 15 - formatting(space
missing after comma) open
create local variables for syai,
access_token, refresh_token,
id_token and reuse them open
Line 73, 125, 144, 155 use use
api.constants.ts instead of hard
coded api paths open
126 error declaration is
deprecated open

You might also like