Upgrade to jQuery 3.5.1 #57
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @delosrogers, I'll have a look to make sure it is working and request that the merge the pull request soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
.click()and.keyup()to.on()and changed the version of jQuery in the package.json to 3.5.1 . I have tested this on my own site and by deploying clustergrammer-web with these changes and I have not seen any errors in the console or encountered any other issues in upgrading versions. It is still possible that there is a part of the library I haven't tested so I am also interested in writing more tests to make sure there aren't any hidden breaking changes in jQuery 3.5.1 .Fixes #56