Skip to content

Adds ability to wrap geometry subtypes with span and a elements + a element functionality within coordinates #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Apr 8, 2021
Merged

Adds ability to wrap geometry subtypes with span and a elements + a element functionality within coordinates #383

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
edc5c6c
Adds ability to wrap geometry subtypes with spans and a
ahmadayubi Mar 26, 2021
0f566f5
Ability to wrap geometry subtypes in links and spans
ahmadayubi Mar 29, 2021
1cb4eac
Link update
ahmadayubi Mar 30, 2021
62c8419
Templated tile fix
ahmadayubi Mar 30, 2021
c58e1b7
Add support for links within coordinates
ahmadayubi Mar 31, 2021
e747c73
Adds link tests
ahmadayubi Apr 1, 2021
4f8bd0d
Removes handlers, might be needed in the future
ahmadayubi Apr 1, 2021
4f242a8
Remove redundant self case
ahmadayubi Apr 1, 2021
4d3b49f
Fix JSHints
ahmadayubi Apr 1, 2021
631796b
Add annotated testing links - run root index.html to view
prushforth Apr 2, 2021
bd6df26
Merge pull request #1 from prushforth/featureLink
ahmadayubi Apr 6, 2021
fc9394a
Fix popup + add type attribute to map-a
ahmadayubi Apr 6, 2021
e48e9b0
Adds group link behavior
ahmadayubi Apr 7, 2021
bb6c37c
Fix grouping, and update test
ahmadayubi Apr 7, 2021
ae3561d
Fix single feature behavior
ahmadayubi Apr 7, 2021
32a575a
Resolve conflict
ahmadayubi Apr 7, 2021
9170320
Remove unneeded changes
ahmadayubi Apr 8, 2021
ef838df
Adds text/html link tests
ahmadayubi Apr 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix JSHints
  • Loading branch information
@ahmadayubi
ahmadayubi committed Apr 1, 2021
commit 4d3b49fe2fdcfafbc9fff4a9055f37d588b68e8d
2 changes: 1 addition & 1 deletion src/mapml/features/feature.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export var Feature = L.Path.extend({
}, this);
L.DomEvent.on(path, "keypress", (e) => {
if (e.keyCode === 13 || e.keyCode === 32)
this._handleLink(link, linkType)
this._handleLink(link, linkType);
}, this);
},

Expand Down
2 changes: 1 addition & 1 deletion src/mapml/features/featureRenderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export var FeatureRenderer = L.SVG.extend({
layer.group.appendChild(p.path);
if (interactive){
if(layer.options.link) layer.attachLinkHandler(p.path, layer.options.link, layer.options.linkType);
layer.addInteractiveTarget(p.path)
layer.addInteractiveTarget(p.path);
}

if(!outlineAdded && layer.pixelOutline) {
Expand Down