fix #16412 elixir outer enum bug#20587
Merged
mrmstn merged 1 commit intoOpenAPITools:masterfrom Feb 4, 2025
Merged
Conversation
mrmstn
approved these changes
Feb 4, 2025
Contributor
There was a problem hiding this comment.
Hi @montague,
Thanks for the PR and the fix of the issue. LGTM and pipline is green as well
Given the error description of #16412 (comment) I think this won't break anything and should fix the enum issue.
I'll check if I can merge this in the upcomimng days, so this will be included in the next release
Contributor
|
Amazing work, thank you! I'm going to test generating the ory SDKs from this commit, and validate that end use cases work. |
Contributor
Author
|
I realized I may have only fixed a part of the issue. Keep me updated on your use case @tobbbles. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where an outer enum isn't properly deserialized in the generated Elixir client. See this issue. #16412
I added one test to exercise the failure case, which I got from this PR #19435 as I was searching to see if anyone else had been having the same problem I ran into.
@tobbbles I grabbed your failing test from #19435 and included it here to speed things up. Thank you for your prior work on this. It pointed me in the right direction.
Real team effort here!
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)Relates to #16412
This PR fixes a bug in the Elixir generator @mrmstn