[#41908] [Backport93 - Backport #5844][Open] Can't install ruby-debug-base19 — Brian Osborne <bosborne11@...>
3 messages
2012/01/05
[#41916] Proposal: Bitmap Marking GC — Narihiro Nakamura <authornari@...>
Hi.
18 messages
2012/01/05
[#41919] Re: Proposal: Bitmap Marking GC
— Roger Pack <rogerdpack2@...>
2012/01/05
> And, GC is a little bit slower. But, I think it's in acceptable range.
[#41968] Re: Proposal: Bitmap Marking GC
— Eric Wong <normalperson@...>
2012/01/07
Narihiro Nakamura <[email protected]> wrote:
[#41969] Re: Proposal: Bitmap Marking GC
— KOSAKI Motohiro <kosaki.motohiro@...>
2012/01/07
> Narihiro Nakamura <[email protected]> wrote:
[#41934] feature request: marshallable proc's — Roger Pack <rogerdpack2@...>
Every so often I wish I could do something like
10 messages
2012/01/05
[#41936] Re: feature request: marshallable proc's
— Urabe Shyouhei <shyouhei@...>
2012/01/06
On 2012年01月06日 08:54, Roger Pack wrote:
[#42898] Re: feature request: marshallable proc's
— SASADA Koichi <ko1@...>
2012/02/25
What should happen on the following code?
[#41979] [ruby-trunk - Bug #5865][Open] Exception#== should return false if the classes differ — Hiro Asari <asari.ruby@...>
10 messages
2012/01/08
[#41997] [ruby-trunk - Bug #5865] Exception#== should return false if the classes differ
— Hiro Asari <asari.ruby@...>
2012/01/09
[#42000] Re: [ruby-trunk - Bug #5865] Exception#== should return false if the classes differ
— Yukihiro Matsumoto <matz@...>
2012/01/09
Hi,
[#42002] Re: [ruby-trunk - Bug #5865] Exception#== should return false if the classes differ
— Nikolai Weibull <now@...>
2012/01/09
On Mon, Jan 9, 2012 at 12:43, Yukihiro Matsumoto <[email protected]> wrote=
[#42003] [ruby-trunk - Bug #5871][Open] regexp \W matches some word characters when inside a case-insensitive character class — Gareth Adams <gareth@...>
14 messages
2012/01/09
[#42016] [ruby-trunk - Feature #5873][Open] Adopt FFI over DL — Heesob Park <phasis@...>
15 messages
2012/01/10
[#42035] [ruby-trunk - Feature #5873] Adopt FFI over DL
— Heesob Park <phasis@...>
2012/01/10
[#42125] Re: [ruby-trunk - Feature #5873] Adopt FFI over DL
— Aaron Patterson <tenderlove@...>
2012/01/13
On Tue, Jan 10, 2012 at 10:01:26PM +0900, Heesob Park wrote:
[#42127] Re: [ruby-trunk - Feature #5873] Adopt FFI over DL
— Nobuyoshi Nakada <nobu@...>
2012/01/14
Hi,
[#42129] Re: [ruby-trunk - Feature #5873] Adopt FFI over DL
— KOSAKI Motohiro <kosaki.motohiro@...>
2012/01/14
> To remove original DL completely, we have to bundle libffi itself
[#42042] RUBY 2 RCR: remove Thread#raise — Roger Pack <rogerdpack2@...>
Hello.
6 messages
2012/01/10
[#42061] Re: RUBY 2 RCR: remove Thread#raise
— Eric Wong <normalperson@...>
2012/01/11
Roger Pack <[email protected]> wrote:
[#42049] [ruby-trunk - Bug #5877][Open] Poor performance of initial and final UTF-8 substrings — Nathan Weizenbaum <nex342@...>
4 messages
2012/01/10
[#42063] [ruby-trunk - Bug #5884][Open] Float::NAN and 0.0/0.0 is represented differently when packed with 'g' — Hiro Asari <asari.ruby@...>
9 messages
2012/01/11
[#42080] [ruby-trunk - Bug #5887][Open] The documentation of Module.constants is incorrect — Shugo Maeda <redmine@...>
9 messages
2012/01/12
[#42085] [ruby-trunk - Bug #5888][Open] JSON unittest fails — Vit Ondruch <v.ondruch@...>
13 messages
2012/01/12
[#42093] Backport93 help needed for a few Windows requests? — Jon <jon.forums@...>
Currently the following Windows-specific backport requests to ruby_1_9_3 remain unassigned:
4 messages
2012/01/12
[#42113] [ruby-trunk - Feature #5893][Open] named return,next... — Ondrej Bilka <neleai@...>
7 messages
2012/01/13
[#42114] Re: [ruby-trunk - Feature #5893][Open] named return,next...
— Anurag Priyam <anurag08priyam@...>
2012/01/13
On Fri, Jan 13, 2012 at 7:21 PM, Ondrej Bilka <[email protected]> wrote:
[#42115] Re: [ruby-trunk - Feature #5893][Open] named return,next...
— Ondřej Bílka <neleai@...>
2012/01/13
On Fri, Jan 13, 2012 at 11:11:28PM +0900, Anurag Priyam wrote:
[#42139] [ruby-trunk - Feature #5898][Open] raise and Exception#initialize — Thomas Sawyer <transfire@...>
10 messages
2012/01/16
[#42149] [ruby-trunk - Feature #5899][Open] chaining comparsions. — Ondrej Bilka <neleai@...>
12 messages
2012/01/16
[#42160] [ruby-trunk - Bug #5902][Open] Array#join with an unused, infected separator may or may not infect the result — John Firebaugh <john.firebaugh@...>
8 messages
2012/01/17
[#42164] [ruby-trunk - Feature #5903][Open] Optimize st_table (take 2) — Yura Sokolov <funny.falcon@...>
18 messages
2012/01/17
[#42189] [ruby-trunk - Bug #5914][Open] Calling extend with an anonymous module requires use of parentheses — Mark Somerville <mark@...>
3 messages
2012/01/20
[#42194] [ruby-trunk - Bug #5915][Open] Array#join with explicit nil should not use $, — John Firebaugh <john.firebaugh@...>
10 messages
2012/01/20
[#42222] [ruby-trunk - Bug #5925][Open] Lazy initialization is not thread safe. — Xuân Baldauf <xuan--2009--xbaldauf--redmine.ruby-lang.org@...>
5 messages
2012/01/23
[#42235] [ruby-trunk - Bug #5931][Open] Random SEGV during execution on YARD specs — Vit Ondruch <v.ondruch@...>
9 messages
2012/01/26
[#42246] Fwd: RCR String#{last, first} — Roger Pack <rogerdpack2@...>
Hello.
6 messages
2012/01/27
[#42256] [ruby-trunk - Feature #5945][Open] Add the ability to mark a at_exit as process-local. — Robert Gleeson <rob@...>
4 messages
2012/01/30
[#42257] [Backport93 - Backport #5942][Open] Backport r34309-34310 r34312-32414 — Yura Sokolov <funny.falcon@...>
4 messages
2012/01/30
[#42285] Why Ruby 1.9 GUI hangs if i do any intensive computation in separate Ruby thread? — Grigory Petrov <grigory.v.p@...>
Hello
4 messages
2012/01/31
[#42286] Re: Why Ruby 1.9 GUI hangs if i do any intensive computation in separate Ruby thread?
— "Haase, Konstantin" <Konstantin.Haase@...>
2012/01/31
the GIL is *not* supposed to lift if some threads enters native code...
[ruby-core:42017] Re: [ruby-trunk - Bug #5865] Exception#== should return false if the classes differ
From:
Nobuyoshi Nakada <nobu@...>
Date:
2012-01-10 02:34:25 UTC
List:
ruby-core #42017
Hi,
(12/01/09 22:02), Nikolai Weibull wrote:
> The fix should be to also check the #class of obj against the #class
> of exc, not to simply ignore it if the rb_obj_class()es don’t match.
> I’ve attached a patch.
Fixnum#== works fine with Delegator because of implicit conversion, so
I think Exception should also use same way.
diff --git a/error.c b/error.c
index 6844f99..7185d52 100644
--- a/error.c
+++ b/error.c
@@ -732,10 +732,14 @@ exc_equal(VALUE exc, VALUE obj)
CONST_ID(id_mesg, "mesg");
if (rb_obj_class(exc) != rb_obj_class(obj)) {
- ID id_message, id_backtrace;
+ ID id_message, id_backtrace, id_exception;
CONST_ID(id_message, "message");
CONST_ID(id_backtrace, "backtrace");
+ CONST_ID(id_exception, "exception");
+ obj = rb_check_funcall(obj, id_exception, 0, 0);
+ if (obj == Qundef) return Qfalse;
+ if (rb_obj_class(exc) != rb_obj_class(obj)) return Qfalse;
mesg = rb_check_funcall(obj, id_message, 0, 0);
if (mesg == Qundef) return Qfalse;
backtrace = rb_check_funcall(obj, id_backtrace, 0, 0);
diff --git a/test/ruby/test_exception.rb b/test/ruby/test_exception.rb
index 028391d..7226fe2 100644
--- a/test/ruby/test_exception.rb
+++ b/test/ruby/test_exception.rb
@@ -380,4 +380,9 @@ end.join
load(t.path)
end
end
+
+ def test_equal
+ assert_equal(RuntimeError.new("a"), RuntimeError.new("a"))
+ assert_not_equal(RuntimeError.new("a"), StandardError.new("a"))
+ end
end
--
Nobu Nakada