[#42344] [ruby-trunk - Feature #5964][Open] Make Symbols an Alternate Syntax for Strings — Tom Wardrop <tom@...>

23 messages 2012/02/03

[#42443] [ruby-trunk - Bug #5985][Open] miniruby skews "make benchmark" results — Eric Wong <normalperson@...>

21 messages 2012/02/08

[#42444] [ruby-trunk - Bug #5986][Open] Segmentation Fault — Luis Matta <levmatta@...>

16 messages 2012/02/08

[#42471] [ruby-trunk - Feature #5995][Open] calling io_advise_internal() in read_all() — Masaki Matsushita <glass.saga@...>

20 messages 2012/02/10

[#42560] [ruby-trunk - Bug #6011][Open] ruby-1.9.3-p0/lib/webrick/utils.rb:184: [BUG] Segmentation fault — Vit Ondruch <v.ondruch@...>

12 messages 2012/02/13

[#42579] [ruby-trunk - Bug #6012][Open] Proc#source_location also return the column — Roger Pack <rogerpack2005@...>

14 messages 2012/02/14

[#42685] [ruby-trunk - Bug #6036][Open] Test failures in Fedora Rawhide/17 — Bohuslav Kabrda <bkabrda@...>

14 messages 2012/02/16

[#42697] [ruby-trunk - Bug #6040][Open] Transcoding test failure: Big5 to UTF8 not defined (MinGW) — Luis Lavena <luislavena@...>

10 messages 2012/02/16

[#42813] [ruby-trunk - Feature #6065][Open] Allow Bignum marshalling/unmarshalling from C API — Martin Bosslet <Martin.Bosslet@...>

22 messages 2012/02/23

[#42815] [ruby-trunk - Bug #6066][Open] Fix "control may reach end of non-void function" warnings for clang — Eric Hodel <[email protected]>

15 messages 2012/02/23

[#42857] [ruby-trunk - Feature #6074][Open] Allow alias arguments to have a comma — Thomas Sawyer <transfire@...>

20 messages 2012/02/24

[#42891] [ruby-trunk - Feature #6083][Open] Hide a Bignum definition — Koichi Sasada <redmine@...>

23 messages 2012/02/25

[#42906] [ruby-trunk - Bug #6085][Open] Treatment of Wrong Number of Arguments — Marc-Andre Lafortune <ruby-core@...>

14 messages 2012/02/25

[#42949] [ruby-trunk - Bug #6089][Open] Test suite fails with OpenSSL 1.0.1 — Vit Ondruch <v.ondruch@...>

13 messages 2012/02/26

[ruby-core:42330] Re: [RFC/PATCH] reinit signal_thread_list_lock atfork

From: Eric Wong <normalperson@...>
Date: 2012-02-02 22:39:47 UTC
List: ruby-core #42330
Eric Wong <[email protected]> wrote:
> also applies to trunk.  I cannot reproduce the original issue since I
> don't have access to a FreeBSD machine, so this patch is a
> stab-in-the-dark for me.
> 
> I've only ensured this patch doesn't break existing behavior under
> Linux/NPTL, not that it fixes a real problem under FreeBSD.

Of course, since I couldn't test/confirm, I just realized
function/#ifdef ordering was wrong and the original patch was a no-op :x

I've squashed the ordering change and replaced the "sig-th-list-atfork"
branch on git://bogomips.org/ruby.git with
commit e39ddff24902e8f605612445b93dd63ff6e9b855:

diff --git a/thread_pthread.c b/thread_pthread.c
index 52997ec..3cb4ca1 100644
--- a/thread_pthread.c
+++ b/thread_pthread.c
@@ -154,13 +154,6 @@ gvl_destroy(rb_vm_t *vm)
     native_mutex_destroy(&vm->gvl.lock);
 }
 
-static void
-gvl_atfork(rb_vm_t *vm)
-{
-    gvl_init(vm);
-    gvl_acquire(vm, GET_THREAD());
-}
-
 #define NATIVE_MUTEX_LOCK_DEBUG 0
 
 static void
@@ -443,6 +436,16 @@ Init_native_thread(void)
 }
 
 static void
+gvl_atfork(rb_vm_t *vm)
+{
+#ifdef USE_SIGNAL_THREAD_LIST
+    native_mutex_initialize(&signal_thread_list_lock);
+#endif
+    gvl_init(vm);
+    gvl_acquire(vm, GET_THREAD());
+}
+
+static void
 native_thread_init(rb_thread_t *th)
 {
     native_cond_initialize(&th->native_thread_data.sleep_cond, RB_CONDATTR_CLOCK_MONOTONIC);
-- 
Eric Wong

In This Thread