[#51213] [ruby-trunk - Bug #7645][Open] BigDecimal#== slow when compared to true/false — "mathie (Graeme Mathieson)" <mathie@...>

11 messages 2013/01/01

[#51328] [ruby-trunk - Bug #7676][Open] Comparison of Float::NAN in array behaves unexpectedly — "simonrussell (Simon Russell)" <spam+ruby@...>

11 messages 2013/01/09

[#51347] [ruby-trunk - Bug #7679][Open] IRB history is broken — "zzak (Zachary Scott)" <zachary@...>

15 messages 2013/01/10

[#51389] [ruby-trunk - Bug #7688][Open] Error hiding with rb_rescue() on Comparable#==, #coerce and others — "Eregon (Benoit Daloze)" <redmine@...>

34 messages 2013/01/11

[#51430] [ruby-trunk - Bug #7696][Open] Lazy enumerators with state can't be rewound — "marcandre (Marc-Andre Lafortune)" <ruby-core@...>

15 messages 2013/01/14

[#51437] [ruby-trunk - Bug #7698][Open] RubyGems 2.0 has an incompatibility about installation of extension libraries — "mrkn (Kenta Murata)" <muraken@...>

21 messages 2013/01/15

[#51454] [CommonRuby - Feature #7701][Open] Non-optional (required) keyword args — "headius (Charles Nutter)" <headius@...>

31 messages 2013/01/15

[#51499] [ruby-trunk - Feature #7712][Open] Add .txt extensions to all plain-text documentation files for Windows users — "postmodern (Hal Brodigan)" <postmodern.mod3@...>

9 messages 2013/01/18

[#51619] [ruby-trunk - Feature #7738][Open] Deprecate Set#+ as an alias of Set#|, use it for symmetric difference. Introduce Hash#| for Hash#reverse_merge in Rails. — "alexeymuranov (Alexey Muranov)" <redmine@...>

11 messages 2013/01/24

[#51623] [ruby-trunk - Feature #7739][Open] Define Hash#| as Hash#reverse_merge in Rails — "alexeymuranov (Alexey Muranov)" <redmine@...>

24 messages 2013/01/24

[#51714] [CommonRuby - Feature #7747][Open] Expanded API for Binding semantics — "jballanc (Joshua Ballanco)" <jballanc@...>

19 messages 2013/01/27

[#51742] [ruby-trunk - Bug #7756][Open] clang 3.2 sees through UNINITIALIZED_VAR macro, gives warning — "drbrain (Eric Hodel)" <[email protected]>

10 messages 2013/01/29

[#51763] [ruby-trunk - Bug #7758][Open] Ruby on Windows crashes when active codepage is codepage 65001 and outputting unicode character — "joshc (Josh C)" <josh.nw@...>

16 messages 2013/01/30

[ruby-core:51289] [ruby-trunk - Bug #7668][Assigned] set_trace_func and TracePoint don't handle exception in finish frame

From: "ko1 (Koichi Sasada)" <redmine@...>
Date: 2013-01-07 06:01:29 UTC
List: ruby-core #51289
Issue #7668 has been reported by ko1 (Koichi Sasada).

----------------------------------------
Bug #7668: set_trace_func and TracePoint don't handle exception in finish frame 
https://bugs.ruby-lang.org/issues/7668

Author: ko1 (Koichi Sasada)
Status: Assigned
Priority: Urgent
Assignee: ko1 (Koichi Sasada)
Category: core
Target version: 2.0.0
ruby -v: ruby 2.0.0dev (2013-01-07 trunk 38719) [i686-linux]



The following code should trap exception correctly (should output ":ok"):

####
def m
  a = 1
  b = 2
  c = 3
  raise
end

trace = TracePoint.new{|tp|
  p tp
  raise # if tp.event == :c_return # if tp.event == :b_return
}

begin
  trace.enable{
    m
  }
rescue => e
  p :ok
end
####

But it outputs same event hook infinite:

#<TracePoint:b_call@/home/ko1/src/ruby/trunk/test.rb:15>
#<TracePoint:b_return@/home/ko1/src/ruby/trunk/test.rb:15>
#<TracePoint:c_return `enable'@/home/ko1/src/ruby/trunk/test.rb:15>
#<TracePoint:c_return `enable'@/home/ko1/src/ruby/trunk/test.rb:15>
#<TracePoint:c_return `enable'@/home/ko1/src/ruby/trunk/test.rb:15>
...

It is a bug.

This patch solve this issue:

Index: vm_trace.c
===================================================================
--- vm_trace.c	(revision 38718)
+++ vm_trace.c	(working copy)
@@ -316,7 +316,12 @@ rb_threadptr_exec_event_hooks_orig(rb_tr
 	th->vm->trace_running--;
 
 	if (state) {
-	    if (pop_p) th->cfp = RUBY_VM_PREVIOUS_CONTROL_FRAME(th->cfp);
+	    if (pop_p) {
+		if (VM_FRAME_TYPE_FINISH_P(th->cfp)) {
+		    th->tag = th->tag->prev;
+		}
+		th->cfp = RUBY_VM_PREVIOUS_CONTROL_FRAME(th->cfp);
+	    }
 	    TH_JUMP_TAG(th, state);
 	}
 	th->state = outer_state;


Output:
#<TracePoint:b_call@../trunk/test.rb:15>
#<TracePoint:b_return@../trunk/test.rb:15>
:ok




-- 
http://bugs.ruby-lang.org/

In This Thread

Prev Next