ruby-core

Issue #13513 has been updated by shyouhei (Shyouhei Urabe).

Status changed from Open to Assigned
Assignee set to akr (Akira Tanaka)

----------------------------------------
Bug #13513: Resolv::DNS::Message.decode hangs after detecting truncation in UDP messages
https://bugs.ruby-lang.org/issues/13513#change-65808

* Author: iamasmith (Andrew Smith)
* Status: Assigned
* Priority: Normal
* Assignee: akr (Akira Tanaka)
* Target version: 
* ruby -v: 
* Backport: 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN
----------------------------------------
ruby-core:32407 introduced support for a TCP requestor in fetch_resource if Resolv::DNS::Message.decode returned RCode::NoError and a reply tc of 1.

Unfortunately Resolv::DNS::Message.decode proceeds to attempt to unpack all answers based upon the answer count from the message regardless of truncation which causes exception behaviour which is then silently retried as this is seen as the response to the request never being seen (see begin, ensure).

To avoid this issue I add a return to Message.decode once the truncation is detected.

To patch this in a portable fashion I use the attached monkey patch which causes the truncation to propagate correctly back to fetch_resource and allows it to proceed correctly with the TCP based query.

---Files--------------------------------
resolv-monkey-tc.rb (757 Bytes)


-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:[email protected]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>