[ruby-core:84507] Re: [Ruby trunk Bug#14243][Rejected] Comments inside ERB tags broken

From: Eric Wong <normalperson@...>
Date: 2017-12-27 11:09:12 UTC
List: ruby-core #84507
[email protected] wrote:
> Status changed from Assigned to Rejected
> 
> https://github.com/ruby/ruby/commit/abbfc048c5890e8017360bbc845062ea1585e155#diff-e1ea8366d3ac334deab7e0d25309be03 does trigger this behavior, but ERB does not support "<% #" syntax. Do you think the code generated at "Before:" is correct? It generates `_erbout.<< -"\n"` as comment but obviously it's not intended. I even think raising an error is better, and the behaivor is out of scope for support as ERB level because embedding invalid syntax Ruby code is always invalid.
> 
> See also Bug#1868. Use "<%#" instead of "<% #".

I understand your reasoning for the change; but I think
completely breaking something which was even half-working
should have a deprecation period of several years.

Otherwise existing users will be tempted to abandon ERb or even
Ruby (this happened with Ruby 1.9).  Basically, this is why I
trust Linux kernel developers; they will jump through hoops to
not break userspace.

Unsubscribe: <mailto:[email protected]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>

In This Thread

Prev Next